[ http://jira.jboss.com/jira/browse/JBMAIL-54?page=comments#action_12316831 ] Michael Barker commented on JBMAIL-54: --------------------------------------
Fixed MailBody.java (using MBean properties and comp/env variables for mbean and ejbs respectively). There is still one case of a hardcoded mbean name in Mailbox.java > Remove ALL hardcoded MBEAN NAMES!!! > ----------------------------------- > > Key: JBMAIL-54 > URL: http://jira.jboss.com/jira/browse/JBMAIL-54 > Project: JBoss Mail > Type: Task > Components: Mail Server APIs, POP, Security, SMTP > Versions: 1.0-M3 > Reporter: Andrew Oliver > Assignee: Michael Barker > Priority: Critical > Fix For: 1.0-M3 > > Original Estimate: 3 hours > Remaining: 3 hours > > There are hardcoded MBean names... > ... > public abstract class MailBody > { > ... > public final static String MAILBODY_MANAGER_NAME = > "jboss.mail:type=MailServices,name=MailBodyManager"; > These should nver be in code but should always be externalized. For one > there might be multiple instances of JBMS hosted in the same appserver which > would require different domains. Moreover its just naughty :-) > I assigned this to Mike because I only see this in the store code so far. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ JBoss-Development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jboss-development
