Right, that's the other part to this. I'd need to change the hibernate-int module to depend on this new hibernate "release". Then it is a matter of specifying to use javassist over cglib as a config parameter. The interesting thing here, though, is that this setting is global to a classloader (scoped by a static variable). Should this be something we make a JBoss config option? Otherwise, I could just set a system property when the MBean first starts up and hope that no one has yet loaded that particular class.
Bill/Emmanuel, will need to do the similiar for the ejb3 module. BTW, anyone have intellij projects files for 4x and head they would share? -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Scott M Stark Sent: Wednesday, April 26, 2006 10:08 AM To: jboss-development@lists.sourceforge.net Subject: RE: [JBoss-dev] Upgrading cglib dependency to version 2.1.3 in 4.0branch The binaries in the repository have to be treated as releases. As soon a version is out there you have to consider that its being used and that any change to it will break existing usage. If 3.2.0.CR2 is just repacked with different configurations/dependencies I would call it 3.2.0.CR2-jboss or perhaps 3.2.0.CR2-javassist(qualifiers to the base are allowed). How does the javassist reference magically configure hibernate to use the javassist bytecode generation by default? Based on Steve's previous comments this still requires additional configuration in jbossas, and so a 3.2.0.CR2-javassist or 3.2.0.CR3 that expresses a dependency on javassist in of itself seems broken because simply pulling this version into jbossas will not work? I linked the JBAS-3101 issue to the HIBERNATE-34 issue to tie it into the 4.0.4.GA release. > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On > Behalf Of Ruel Loehr > Sent: Wednesday, April 26, 2006 7:48 AM > To: jboss-development@lists.sourceforge.net > Subject: RE: [JBoss-dev] Upgrading cglib dependency to > version 2.1.3 in 4.0branch > > You would want to create a new version. The older version > which uses > cglib should remain for historic reasons. > > For example if 4.0.3.SP1 uses a hibernate version that is > dependent upon cglib, we may want to reproduce that build > sometime in the future (doing a service pack). > > Modifying the component-info.xml of 3.2.0.CR2 if it has > previously been included in a release will break the repeatability. > > Ruel Loehr > JBoss QA > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On > Behalf Of Steve Ebersole > Sent: Wednesday, April 26, 2006 9:31 AM > To: jboss-development@lists.sourceforge.net > Subject: RE: [JBoss-dev] Upgrading cglib dependency to > version 2.1.3 in 4.0branch > > Quick question about this actually. > > 3.2.0.CR2 exists in the respository, specifying cglib, as a > dependency and has already been used in one of the 4.0.3 CR > releases, correct? > > So what is the policy on changing the component def of a > component when that particular release has already been used > in a AS release? Meaning, is it kosher for me to simply > change hibernate/3.2.0.CR2/component.xml to reference > javassist instead of cglib at this point? Or do I copy > hibernate/3.2.0.CR2 into a new hibernate/3.2.0.CR3 (same stuff as > before) and modify that component.xml to reference javassist? > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On > Behalf Of Steve Ebersole > Sent: Tuesday, April 25, 2006 1:29 PM > To: jboss-development@lists.sourceforge.net > Subject: RE: [JBoss-dev] Upgrading cglib dependency to > version 2.1.3 in 4.0branch > > Based on previous discussions, we actually plan on making > Javassist the utilized provider within JBoss AS. > > http://jira.jboss.com/jira/browse/HIBERNATE-34 > > I was unable to assign this to a particular release, however > it should get done prior to 4.0.4 goes GA. ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=k&kid0709&bid&3057&dat1642 _______________________________________________ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642 _______________________________________________ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
