I'll do it. Thanks Craig. Simon > -----Original Message----- > From: Ralf Purnhagen [mailto:[EMAIL PROTECTED]] > Sent: venerdì 26 gennaio 2001 12:15 > To: jBoss > Subject: [jBoss-User] Re: SpyderMQ/deployment problems > > > This patch works for me. Can somebody please commit this to CVS or > does it break something? > > Ralf > > Craig Day wrote: > > > > its in the JMS monitoring. init, start, stop and destroy dont call > > isJMSMonitoringEnabled() > > before setting up or cleaning up like the logActivation() > etc call does. > > Ive made the fix, how > > do I contribute this into CVS? Ive included the diff below. > > > > cheers > > craig > > > > cvs diff AbstractInstanceCache.java (in directory > > C:\cvsroot\jboss\src\main\org\jboss\ejb\plugins\) > > Index: AbstractInstanceCache.java > > =================================================================== > > RCS file: > > > /products/cvs/ejboss/jboss/src/main/org/jboss/ejb/plugins/Abst > ractInstanceCache.java,v > > retrieving revision 1.4 > > diff -r1.4 AbstractInstanceCache.java > > 327,329c327,330 > > < Context namingContext = new InitialContext(); > > < Object factoryRef = > > namingContext.lookup("TopicConnectionFactory"); > > < TopicConnectionFactory factory = > > (TopicConnectionFactory)PortableRemoteObject.narrow(factoryRef, > > TopicConnectionFactory.class); > > --- > > > if (isJMSMonitoringEnabled()) { > > > Context namingContext = new InitialContext(); > > > Object factoryRef = > > namingContext.lookup("TopicConnectionFactory"); > > > TopicConnectionFactory factory = > > (TopicConnectionFactory)PortableRemoteObject.narrow(factoryRef, > > TopicConnectionFactory.class); > > 331c332 > > < m_jmsConnection = factory.createTopicConnection(); > > --- > > > m_jmsConnection = > factory.createTopicConnection(); > > 333,336c334,338 > > < Object topicRef = > namingContext.lookup("topic/metrics"); > > < m_jmsTopic = > (Topic)PortableRemoteObject.narrow(topicRef, > > Topic.class); > > < m_jmsSession = > m_jmsConnection.createTopicSession(false, > > Session.DUPS_OK_ACKNOWLEDGE); > > < m_jmsPublisher = > m_jmsSession.createPublisher(m_jmsTopic); > > --- > > > Object topicRef = > namingContext.lookup("topic/metrics"); > > > m_jmsTopic = > > (Topic)PortableRemoteObject.narrow(topicRef, Topic.class); > > > m_jmsSession = > > m_jmsConnection.createTopicSession(false, > Session.DUPS_OK_ACKNOWLEDGE); > > > m_jmsPublisher = > m_jmsSession.createPublisher(m_jmsTopic); > > > } > > 344c346,348 > > < m_jmsConnection.start(); > > --- > > > if (isJMSMonitoringEnabled()) { > > > m_jmsConnection.start(); > > > } > > 356,360c360,365 > > < try > > < { > > < m_jmsConnection.stop(); > > < } > > < catch (JMSException ignored) {} > > --- > > > if (isJMSMonitoringEnabled()) { > > > try { > > > m_jmsConnection.stop(); > > > } > > > catch (JMSException ignored) {} > > > } > > 367,371c372,377 > > < try > > < { > > < m_jmsConnection.close(); > > < } > > < catch (JMSException ignored) {} > > --- > > > if (isJMSMonitoringEnabled()) { > > > try { > > > m_jmsConnection.close(); > > > } > > > catch (JMSException ignored) {} > > > > > > > At 02:47 PM 1/24/01 +0100, Rickard Öberg wrote: > > >Hey > > > > > >"Bordet, Simone" wrote: > > > > I also get these and many other have already > complained. I posted this > > > > problem 3 times in JBossMS (how is it called now > spyderMQ ?) but no > > > > answer... > > > > > > > > >From me no clue (I haven't investigated, though), I > just close a JMS > > > > connection in destroy() and create it again in init(), to me > > > > AbstractInstanceCache seems ok. > > > > > >Well, I just tried to fix it The Wrong Way(tm) by simply > adding "catch > > >(Exception ignore) {}" to the close try/catch. "Works", > but the real > > >deal is of course to fix JBossMQ close(). > > > > > >regards, > > > Rickard > > > > > >-- > > >Rickard Öberg > > > > > >Email: [EMAIL PROTECTED] > > > > > > > > >-- > > >-------------------------------------------------------------- > > >To subscribe: [EMAIL PROTECTED] > > >To unsubscribe: [EMAIL PROTECTED] > > >List Help?: [EMAIL PROTECTED] > > > > -- > > -------------------------------------------------------------- > > To subscribe: [EMAIL PROTECTED] > > To unsubscribe: [EMAIL PROTECTED] > > List Help?: [EMAIL PROTECTED] > > > -- > -------------------------------------------------------------- > To subscribe: [EMAIL PROTECTED] > To unsubscribe: [EMAIL PROTECTED] > List Help?: [EMAIL PROTECTED] > -- -------------------------------------------------------------- To subscribe: [EMAIL PROTECTED] To unsubscribe: [EMAIL PROTECTED] List Help?: [EMAIL PROTECTED]
