Dirk Kraemer wrote:

Hi all,

maybe I missed it on the list, just some minor questions:

Is the multidb extension complete from your point of view?
ahemmm... never tested... 8^(

1) As far as I can see, we have still the two names

'id' and 'dbConnectionName'

for what should be the same.
"id" into the dbforms config file and "dbConnectionName" as a tag parameter, is it right ?

2) I'm still not sure what will be the default connection:

I think it should be: the one and only connection
  without an explicit name. That would also be backwards compatible.
And if there are 2 dbconnections both with a name ?
It could be:

the first dbconnection on the list become the default connection;
if any other connection has got a defaultConnection attribute set to true, that connection will be the default one. OR...

Looks like it is: the first connection within config file,
  even if it has a name.
... we should use the name attribute to (not) indicate the default connection... the connection without a name is the default one.
The attribute "defaultConnection" will be deprecated.


And there is also an attribute 'defaultConnection' 'defaultConnection' that is used within
code, but not explained anywhere.

'defaultConnection' as DbConnection attribute ?
It should tag a DbConnection class as the default DbConnection class...
We should decide to keep this one or not. If we use the dbconnection name to decide what is the default connection, we can remove this attribute.


The documentation must also be extended to explain which con will be
taken if no dbConnectionName is set.

3) Looks like every DbFormTag creates a new connection, even if it uses
 the same connection as an outer tag. What about the idea of reusing
 the outer connection again?

Is somebody still working on the extension?
I think no.
The best thing to do (IMHO) is to start to look at this code, understand how it works, explain it and decide a common behaviour.
Then make this code follows this behaviour.

Now I'm working on the event engine ... I'd like to commit this stuff, then I could help someone on this topic.

Regards

Dirk

Regards,
Luca



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
DbForms Mailing List

http://www.wap-force.net/dbforms

Reply via email to