Are you suggesting that this filter can replace a whereClause attribute, or just the current filter attribute?
The current use of filter is that it gets ignored if a whereClause is specified. Is that also the case with yours?
Techincally speaking, I can not vote right one way or the other by looking at your code since I don't understand the internals enough, but I need to know usage so the manual can be correct. It looks like your sqlQuery will replace both the whereClause and filter attributes. If so, I give it a +1 because use would be simpler (ie orderBy will always be orderBy and you don't have to worry about if you use orderBy attribute or put it in with whereClause).
If it is a replacement and not just additional functionability, then I guess in terms of backward compatibility 1.1.4 won't be compatible with previous releases. Or could we tell users, this is a better way to do filtering but the filter attribute still works for backwards compatibility?
I've add a new type of filter to dbforms's capability, an sql filter that is simply an SQL condition, passed as a DbFormTag's attribute.
This-- Shawn
type of filter is much better than the old one, but the coding changes are rilevant, so I post here the diff, and we can discuss about it pros and cons and decide what to do.
Happily using M2, Opera's revolutionary e-mail client: http://www.opera.com/m2/
------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ DbForms Mailing List
http://www.wap-force.net/dbforms
