jde-checkstyle.el

[Joshua Spiewak]

Here are some improvements (as diffs to jde 2.2.9) to jde-checkstyle.el

The first diff is the addition of a properties file, since that is the preferred of configuring Checkstyle as of version 2.4 and it makes it much easier to share settings between a build process and JDE.

The second diff is a bug fix for specifying the header file (although I still can't seem to get it to check the header, it works just fine from ant)

The third diff is a bug fix for specifying the jde-checkstyle-classpath. While you could configure this variable, it was not being used. Fixing it allows one to specify a checkstyle-all.jar other than the default, i.e. enables one to use Checkstyle 2.4

The final diff makes use of the properties file from the first diff.

Hope this is helpful. Thanks for a great environment!

-- Josh

105,110d104
< (defcustom jde-checkstyle-properties-file ""
< "*File containing checkstyle properties.
< If non-nil represent the properties file checkstyle should use."
< :group 'jde-checkstyle
< :type 'file)
<
636c630
< (add-to-list 'options (concat "-Dcheckstyle.header.file=" jde-checkstyle-option-header-file)))
---
> (add-to-list 'options (concat "-Djde-checkstyle-option-header-file=" checkstyle.header.file)))
825,829c819,821
< (if jde-checkstyle-classpath
< (list "-classpath" (jde-build-classpath jde-checkstyle-classpath))
< (list "-classpath"
< (jde-build-classpath
< (list (expand-file-name "lib/checkstyle-all.jar" jde-java-directory)))))
---
> (list "-classpath"
> (jde-build-classpath
> (list (expand-file-name "lib/checkstyle-all.jar" jde-java-directory))))
831,832d822
< (if (not (string= jde-checkstyle-properties-file ""))
< (list "-p" jde-checkstyle-properties-file))