Hi Paul,
Thank you for taking in my patch. I have just made the download and tested it,
everything is OK.
Vincent.
> CC: [email protected]
> From: [email protected]
> To: [email protected]
> Subject: Re: [jdee-users] Bug on testing jde-compile-enable-kill-buffer
> Date: Tue, 26 Apr 2011 21:15:08 -0500
>
> This is in. Will you please update your snapshot and test?
>
> BTW--The version numbers you have here are a little off so I had to do
> this manually. Please make sure what's in the repo is what you have.
>
> Thanks.
>
>
> On Apr 24, 2011, at 2:35 AM, Vincent Belaïche wrote:
>
> > Hello all,
> >
> > I came accross a bug on the way jde-compile-enable-kill-buffer is
> > tested. I am proposing the following patch and changelog
> >
> > ----------------- Changelog
> > -------------------------------------------
> > 2011-04-24 Vincent Belaïche <[email protected]>
> >
> > * jde-compile.el (jde-compile-finish-kill-buffer): Test
> > jde-compile-enable-kill-buffer as non-nil only when it is not a
> > number to be consistent with its docstring.
> > -----------------------------------------------------------------------
> >
> > VBR,
> > Vincent.
> >
> > PS: FYI I had to do an update of SVN to be able to get the latest
> > one. I
> > am using MSWindows CollabNet, my previous version was 1.6.11, and the
> > latest one is 1.6.16.
> >
> > Index: jde-compile.el
> >
> > ===================================================================
> >
> > --- jde-compile.el (revision 247)
> >
> > +++ jde-compile.el (working copy)
> >
> > @@ -237,9 +237,9 @@
> >
> > (if (null (or (string-match ".*exited abnormally.*" msg)
> > (string-match ".*BUILD FAILED.*" (buffer-string))))
> > ;;no errors, make the compilation window go away in a few seconds
> > - (if (or (and (numberp jde-compile-enable-kill-buffer)
> > - (not (minusp jde-compile-enable-kill-buffer)))
> > - jde-compile-enable-kill-buffer)
> > + (if (if (numberp jde-compile-enable-kill-buffer)
> > + (not (minusp jde-compile-enable-kill-buffer))
> > + jde-compile-enable-kill-buffer)
> > (lexical-let ((compile-buffer buf))
> > (run-at-time
> > (format "%d sec" (if (numberp jde-compile-enable-kill-buffer)
> > @@ -611,7 +611,7 @@
> >
> >
> > (defcustom jde-compile-enable-kill-buffer -1
> > "* Time in seconds to display the compilation buffer before
> > -'jde-compile-finish-kill-buffer will kill the compilation buffer.
> > +`jde-compile-finish-kill-buffer' will kill the compilation buffer.
> >
> > If less than zero (or nil), do not kill the compilation buffer.
> > If t (or other non-nil non-number) then kill in 2 secs."
> > ------------------------------------------------------------------------------
> > Fulfilling the Lean Software Promise
> > Lean software platforms are now widely adopted and the benefits have
> > been
> > demonstrated beyond question. Learn why your peers are replacing JEE
> > containers with lightweight application servers - and what you can
> > gain
> > from the move.
> > http://p.sf.net/sfu/vmware-sfemails_______________________________________________
> > jdee-users mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/jdee-users
>
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
jdee-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jdee-users
