Some comments :

1) I don't see your name as having signed the SCA. Patches cannot be accepted until you do.
2) Read the open jdk developers guide on how to submit patches.
3) Once you've done that, discuss this enhancement first on 2d-...@openjdk.java.net jdk6-dev is a general alias to do with the jdk7-based backport to create openjdk6 New features should start in the appropriate technology group of the main line project

  For this specific proposal there may be other considerations

1) I'm a bit surprised how large this patch is. I have a version of the code that I modified for JavaFX which needs to run on Mac and accepts mac names. I don't remember it as needing more than an extremely minimal change and I was at some point going to
   pull this back into openjdk anyway.

2) There's a mac port project underway and it'll use some apple donated code.

I'd want to look at both of those first.

-phil.

On 1/11/2011 7:18 AM, Johnson Lau wrote:

于 11-1-11 下午10:54, Dr Andrew John Hughes 写道:
On 22:41 Tue 11 Jan     , Johnson Lau wrote:
Hi,

Some fonts shipping with Mac, like STHeiti / Hiragino series, contains
tags with only Mac Platform ID (=1), which causes them wrongly treated
as invalid format by OpenJDK because OpenJDK recognizes name tags with
Platform ID of MS_PLATFORM_ID (=3) ONLY currently.

I added support for MAC_PLATFORM_ID and other possible values to make it
work in both OpenJDK 6&  7.

Also, there is a patch backporting OpenType font support for OpenJDK 6.


If you mean:

changeset:   406:acb763ebef95
user:        prr
date:        Thu May 27 08:53:45 2010 -0700
summary:     6954424: Support OpenType/CFF fonts in JDK 7

it's already in OpenJDK6.

Sorry for the silly mistake.
Just checked with my local copy.
It seems that I worked on an out-dated b20 copy and the file has been changed since then.
Updated patches attached.

-Johnson

Reply via email to