Dr Andrew John Hughes wrote:
On 12:27 Tue 18 Jan , Joe Darcy wrote:
On 1/11/2011 1:03 PM, Dr Andrew John Hughes wrote:
On 11:36 Tue 11 Jan , Joe Darcy wrote:
On 1/11/2011 10:19 AM, Dr Andrew John Hughes wrote:
On 09:43 Tue 11 Jan , Joe Darcy wrote:
Joe Darcy wrote:
On 1/10/2011 12:24 PM, Dr Andrew John Hughes wrote:
On 11:26 Mon 10 Jan , Joe Darcy wrote:
snip...
Hello.
Since you haven't run into any issues with having 7002666 in IcedTea6
1.9, I'm satisfied to have it this build of OpenJDK 6, which should
bring b21 to a close!
-Joe
I've pushed 7002666:
http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/499d2ae376ee
along with two PNG backports that were approved for Deepak Bhole some
time
ago but were never done:
http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/0e72e58a762d
http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c267a33e76b0
(copyright headers updated appropriately).
Let's get b21 out the door! :-)
Agreed! Later this week, I'll go through my pre-promotion build and
test cycle.
-Joe
When running the HotSpot regression tests, I see two failures:
Compilation failed: Compilation failed
* gc/6581734/Test6581734.java : CMS Old Gen's collection usage is
zero after GC which is incorrect
Execution failed: exit code 127
* runtime/6929067/Test6929067.sh : Stack guard pages should be
removed when thread is detached
The first is due to a typo in the test case; I approve the backport of
6980392 "TEST_BUG: gc/6581734/Test6581734.java has typo"
http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334
to fix this.
The second test seems to make platform assumptions that aren't always
true, but after some looking around I don't see an existing fix in the
HotSpot repos.
At least the first should be fixed before b21 promotes.
Yes, both of these issues are fixed in IcedTea6, the first with the 6980392
that I've now pushed to OpenJDK6.
Thanks for doing the push.
I recall there was some discussion of a fix for the second with upstream, but
I can't find it right now and Pavel (who found the bug and fixed it) is on
vacation.
One Oracle bug for this test failure seems to be,
6945460 TEST_BUG: runtime/6929067/Test6929067.sh
but it is not marked as fixed in any release.
There was some discussion on IcedTea:
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/011057.html
and at least some on HotSpot:
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-November/010959.html
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-December/011329.html
but I don't see a resolution.
Yes, these are all on the IcedTea mailing list. I recall some discussion
on the HotSpot mailing lists but I can't find any.
The patch is in IcedTea6 as patches/jtreg-6929067-fix.patch. As I said, Pavel
will
know more but isn't around to comment at the moment.
I'll take a took at the patch; I'd prefer b21 to have a clean HotSpot
regression test run and a fix for that issue will be necessary for that
to happen (I'll other HotSpot regression tests pass).
-joe
Ok I'll ping Pavel directly tomorrow.
Let's not delay b21 much longer, it's already over six months since a release.
There are unreleased javac fixes dating back to last June.
Agreed.
Here are my test results from tip compared to b20:
0: b20-hotspot/summary.txt pass: 85
1: b21-hotspot/summary.txt pass: 97; fail: 1
0 1 Test
--- pass compiler/6431242/Test.java
--- pass compiler/6894807/IsInstanceTest.java
--- pass compiler/6932496/Test6932496.java
--- pass compiler/6946040/TestCharShortByteSwap.java
--- pass compiler/6958485/Test.java
--- pass compiler/6973329/Test.java
--- pass compiler/6982370/Test6982370.java
--- pass compiler/7002666/Test7002666.java
--- pass gc/6581734/Test6581734.java
--- pass runtime/6626217/Test6626217.sh
--- pass runtime/6888954/vmerrors.sh
--- pass runtime/6925573/SortMethodsTest.java
--- fail runtime/6929067/Test6929067.sh
13 differences
0: b20-langtools/summary.txt pass: 1,365
1: b21-langtools/summary.txt pass: 1,391
0 1 Test
--- pass tools/javac/6508981/TestInferBinaryName.java
--- pass tools/javac/6734819/T6734819a.java
--- pass tools/javac/6734819/T6734819b.java
--- pass tools/javac/6734819/T6734819c.java
--- pass tools/javac/6889255/T6889255.java
--- pass tools/javac/T6595666.java
--- pass tools/javac/T6625520.java
--- pass tools/javac/T6705935.java
--- pass tools/javac/T6956638.java
--- pass tools/javac/api/6411310/Test.java
--- pass tools/javac/api/6440333/T6440333.java
--- pass tools/javac/api/6733837/T6733837.java
--- pass tools/javac/api/Sibling.java
--- pass tools/javac/api/T6483788.java
--- pass tools/javac/api/T6501502.java
--- pass tools/javac/api/T6838467.java
--- pass tools/javac/api/T6877206.java
pass --- tools/javac/policy/Test.java
pass --- tools/javac/policy/Test.java#id1
pass --- tools/javac/policy/Test.java#id2
pass --- tools/javac/policy/Test.java#id3
pass --- tools/javac/policy/Test.java#id4
pass --- tools/javac/policy/Test.java#id5
pass --- tools/javac/policy/Test.java#id6
pass --- tools/javac/policy/Test.java#id7
--- pass tools/javac/policy/test1/Test1a.java
--- pass tools/javac/policy/test1/Test1a.java#id1
--- pass tools/javac/policy/test1/Test1a.java#id2
--- pass tools/javac/policy/test1/Test1a.java#id3
--- pass tools/javac/policy/test1/Test1a.java#id4
--- pass tools/javac/policy/test1/Test1a.java#id5
--- pass tools/javac/policy/test1/Test1a.java#id6
--- pass tools/javac/policy/test1/Test1a.java#id7
--- pass tools/javac/policy/test1/Test1b.java
--- pass tools/javac/policy/test1/Test1b.java#id1
--- pass tools/javac/policy/test1/Test1b.java#id2
--- pass tools/javac/policy/test1/Test1b.java#id3
--- pass tools/javac/policy/test2/Test.java
--- pass tools/javac/policy/test2/Test.java#id1
--- pass tools/javac/policy/test2/Test.java#id2
--- pass tools/javac/policy/test2/Test.java#id3
--- pass tools/javac/policy/test3/Test.java
42 differences
0: b20-jdk/summary.txt pass: 3,273; fail: 33; error: 2
1: b21-jdk/summary.txt pass: 3,300; fail: 29; error: 3
0 1 Test
--- pass com/sun/java/swing/plaf/gtk/Test6963870.java
fail pass
java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java
--- pass java/awt/Frame/FrameSize/TestFrameSize.java
fail pass java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
fail pass
java/awt/Multiscreen/LocationRelativeToTest/LocationRelativeToTest.java
fail pass java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.html
--- pass java/awt/font/TextLayout/TestSinhalaChar.java
pass error
java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh
--- pass java/math/BigDecimal/MultiplyTests.java
pass fail java/net/InetAddress/IPv4Formats.java
pass fail java/net/URL/OpenStream.java
pass fail java/net/URLClassLoader/ClassLoad.java
pass fail
java/rmi/transport/rapidExportUnexport/RapidExportUnexport.java
--- pass java/util/logging/AnonLoggerWeakRefLeak.sh
--- pass java/util/logging/LoggerWeakRefLeak.sh
--- pass javax/imageio/plugins/png/ITXtTest.java
--- pass javax/imageio/plugins/png/ItxtUtf8Test.java
--- pass javax/swing/JPopupMenu/6675802/bug6675802.java
--- pass javax/swing/JPopupMenu/6691503/bug6691503.java
--- pass javax/swing/Security/6938813/bug6938813.java
--- pass javax/swing/UIDefaults/6622002/bug6622002.java
--- pass javax/swing/UIDefaults/6795356/SwingLazyValueTest.java
--- pass javax/swing/UIDefaults/6795356/TableTest.java
--- pass javax/swing/UIDefaults/6795356/bug6795356.java
fail pass javax/swing/plaf/synth/Test6933784.java
fail pass sun/nio/cs/Test4200310.sh
--- pass sun/security/pkcs11/SecureRandom/TestDeserialization.java
--- pass sun/security/pkcs11/Signature/TestRSAKeyLength.java
--- pass
sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/InvalidateServerSessionRenegotiate.java
--- fail
sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java
--- pass sun/security/ssl/javax/net/ssl/NewAPIs/JSSERenegotiate.java
--- pass
sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/CheckStatus.java
--- pass
sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/ConnectionTest.java
--- pass
sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/NoAuthClientAuth.java
fail pass
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java
fail pass
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java
fail pass
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPIdentities.java
fail pass
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Identities.java
pass fail sun/security/validator/CertReplace.java
--- pass sun/tools/common/CommonTests.sh
40 differences
This looks sufficiently good to me for b21, regardless of the new
(spurious) test failure in HotSpot.
I'll start the internal procedures to generate the b21 source bundle.
-Joe