On 06/27/2011 10:28 AM, Phil Race wrote:
On 6/27/2011 10:02 AM, Kelly O'Hair wrote:
My testing results running the regression tests in the repositories,
with the jdk/test/Makefile:
..
* Windows: It appears that test case
javax/imageio/plugins/png/ITXtTest.java is not closing a file,
causing tests that follow to fail. The jdk/testMakefile uses
'jtreg -samevm' which expects each
testcase to clean up after itself, on Windows this can cause
cascading failures.
Looking at it I see that it probably is that a created
ImageInputStream isn't being closed
but this can' t be new .. the test is unchanged in 2 1/2 years and is
in build 22.
Are we excluding it in JDK 7? I'd say its simplest to do the same here
and update the test in 8.
BTW although the test may look like its only 6 months old in 6-open
that's because
it was backported to 6-open about 6 months ago. So far as I can tell
although its got
Andrew's name on it, he didn't have any involvement in the back port.
I think ports
should use the openjdk id of the person doing the backport, not the
original author.
-phil.
Phil,
It helps to use jtreg 4.1 b02, and to use -agentvm instead of -samevm.
Agentvm is like samevm, but better. It tries to clean up after tests,
and if it can't, it closes the JVM and starts a new one.
Also, in b03, upcoming, jtreg supports concurrent test execution, if the
tests are up to the challenge.
-- Jon
