----- Original Message ----- > On 05/13/2013 08:26 AM, Andrew Hughes wrote: > >> Webrev at: > >> http://cr.openjdk.java.net/~omajid/webrevs/ignore-jdk6-bugids/00/ > >> > >> Following the earlier discussion [1] where it was suggested that it > >> would be nice to be able to use both Oracle bug ids (for backports from > >> jdk7 and jdk8 projects) and OPENJDK6 bug ids, I got a push fixed to > >> jcheck that adds this capability to jcheck [2]. Now jcheck can, > >> optionally, recognize both Oracle-style and JIRA-style bug ids, but > >> ignore them when checking for duplicates. The webrev turns on this > >> option for jcheck for the jdk6 project. > >> > >> Any thoughts, concerns or suggestions? > >> > > > > Your e-mail suggests jcheck has been fixed to support both types of bug ID. > > The webrev suggests it is being set to ignore them altogether. Can you > > clarify > > what the new behaviour is? > > The 'support' in jcheck is for ignoring them. That is, jcheck will look > at the bug ids, recognize them as bug ids, but perform no further > processing on them. It will check that the bug line is of the style: > > 61234567: Summary > or > FOOBAR42-1234: Summary > > But will not perform duplicate bug id detection or anything of that > sort. Before this patch, jcheck would reject the changeset if presented > with JIRA-style FOOBAR-1234 bugs. >
Yeah, I've already hit that :( > Technically, jcheck can (as of last week) read and parse JIRA-style bug > ids, but I figured allowing jcheck to perform duplicate detection with > multiple bug systems in play might be too risky and result in odd > failures. So I think a better choice is to 'ignore' them. > > Thanks, > Omair > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > Fine by me. Approved. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
