----- Original Message ----- > * Alex Kasko <m...@alexkasko.com> [2013-11-25 10:56]: > > AFAIK it doesn't really matter here because this makefile is windows > > only and this section (in webrev.01) if specific to VS2010 that > > cannot be used to build jdk6. I just changed my "original research" > > fix to the variant from jdk7 > > (http://hg.openjdk.java.net/hsx/jdk7u/hotspot/file/75c36a461ecd/make/windows/makefiles/compile.make). > > I prefer staying as close to upstream as possible.. But I do see a few > other differences in this file and upstream jdk7u. I think we should try > and sync this file completely.
As this security update is already overdue, I'd rather just stick to syncing this particular fix than pulling in a whole bunch of other changes. > > What I am curious about is that upstream enabled SEH for all compilers > [1], including VS 2003. Sounds like if we pull that in the build will > still be broken for you. On 7. Are you sure VS 2003 is even used on 7? My understanding was that /SAFESEH works fine for most of the build, but not the SA (presumably some lib it pulls in). > > Thanks, > Omair > > [1] http://hg.openjdk.java.net/hsx/jdk7u/hotspot/rev/75c36a461ecd > > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
