On 12/06/2013 03:30 PM, Andrew wrote:
----- Original Message -----
On 11/14/2013 12:47 AM, Omair Majid wrote:
Hi,
The attached patch fixes the Change Summary generator included in
openjdk6. OPENDJDK6-* bugs are now generated too. I have included the
update summary page that is generated with this patch (for b27 to b28
jump, compare with [1]).
I will wait for all the security patches to be added before pushing
this, assuming this patch looks okay.
Thanks,
Omair
[1]https://openjdk6.java.net/OpenJDK6-B28-Changes.html
fix-report-generator.patch
diff --git a/make/scripts/jdkreport.pl b/make/scripts/jdkreport.pl
--- a/make/scripts/jdkreport.pl
+++ b/make/scripts/jdkreport.pl
@@ -70,7 +70,12 @@
foreach(@bugs) {
($bugid, $desc) = split ':',$_, 2; # limit the number of splits to 2
$bugid =~ s/^\s+//; #remove leading white spaces
- $url ="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=$bugid";;
+
+ if ($bugid =~ /^OPENJDK6-/) { # use different urls for different bugs
+ $url ="http:/java.net/jira/browse/$bugid";
+ } else {
+ $url ="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=$bugid";;
+ }
if($firstbug) {
$firstbug = 0;
@@ -108,7 +113,7 @@
chomp($changeset); #remove end of line
}
- if(/^\d+:/) { #match lines that start with numbers (bugids)
+ if(/^(OPENJDK6-)?\d+:/) { #match lines that start with numbers (bugids)
push(@bugs, $_);
}
}
changelog.html
I'm not full time reviewer, but except one nit the changes looks ok.
You're not a reviewer at all, in the OpenJDK sense. Sorry.
Yes... I voted especially because Omair will be off to the end of the December.
You can not speed up the change here, can you?
Sorry for disturbing,
J.
In second hunk, the comment is no longer valid, it ssould be:
+ if(/^(OPENJDK6-)?\d+:/) { #match lines that start with OPENJDK5- or with
numbers (both bugids)
So from my "watcher's" position ok to go after fixed comment.
Thankx for keeping jdk6 alive!
J.
I didn't realise you'd posted this or that the script was part of OpenJDK
itself.
I did ok it informally before and do so now formally.
