Hi Alex,
Your patch is a good idea but it needs to be a different commit.
Let's see if there are any objections to Vladislav's proposal.
Thanks,
Ivan
On 24/05/2014 21:19, Alex Kasko wrote:
Hi,
On 05/23/2014 04:07 PM, Andrew Haley wrote:
Hi,
On 05/23/2014 11:36 AM, karnaukh...@gmail.com wrote:
please review the fix for OPENJDK6-32: OpenJDK6-b31 isn't compatible
with Windows platform
webrev: http://cr.openjdk.java.net/~vkarnauk/OPENJDK6-32/webrev.00/
This fix is a follow-up to threads [1], [2], and [3]. It contains
changes necessary to upgrade compilers to VisualStudio 2010, as well
as changes that fix current issues in Windows part of OpenJDK6-b31.
Thanks a lot!
I've built 32-bit and 64-bit versions successfully using Windows SDK
7.1 (without Visual Studio) with the following patch:
$ diff jdk6_vs2010/jdk/src/windows/resource/version.rc version.rc
26c26
< #include "afxres.h"
---
> #include "windows.h"
$ diff jdk6_vs2010/jdk/src/windows/native/sun/windows/awt.rc awt.rc
26c26
< #include "afxres.h"
---
> #include "windows.h"
40,42c40,42
< SECURITY_WARNING_0 ICON DISCARDABLE "security_warning_bw.ico"
< SECURITY_WARNING_1 ICON DISCARDABLE "security_warning_int.ico"
< SECURITY_WARNING_2 ICON DISCARDABLE "security_warning.ico"
---
> SECURITY_WARNING_0 ICON DISCARDABLE "awt.ico"
> SECURITY_WARNING_1 ICON DISCARDABLE "awt.ico"
> SECURITY_WARNING_2 ICON DISCARDABLE "awt.ico"
I guess header changes won't harm and can be applied, I am not sure
about the icons though.
Note about OS support:
AWT is broken in Windows XP (and probably on Windows 2003 too),
jconsole window displayed but the graphics inside it is glitched. I
think that doesn't matter much as XP is already retired and 2003 is
close to it.
Note about Windows SDK (may be obvious to Windows users, just to
clarify the point for non-Windows ones):
Visual Studio 2010 Express Edition is "registerware" - it is free but
requires registration in 30 days. And it does not have 64-bit toolset.
Windows SDK 7.1 (full name: Microsoft Windows SDK for Windows 7 and
.NET Framework 4) is free, has 64-bit toolset and can be used on clean
Windows instance without installation [1]. Its compiler/linker
versions are close to the ones in VS 2010. Support for it in OpenJDK6
will allow to build using free (as in free beer) tools, so if it is
possible - please keep support for it.
Thank you. This all looks reasonable enough, but it is a huge patch
and rather a lot to take in one bite. I have studied it, and it all
looks reasonable enough. I am minded to commit these patches as they
are, since that moves us much closer to proper Windows support.
I'm not working on Windows, so I can't much comment on the finer
technical details. I'm going to leave it up for people to comment for
a couple of days and then check it in.
Thanks,
Andrew.
[1]
http://stackoverflow.com/questions/13571628/compiling-c-code-using-windows-sdk-7-1-without-net-framework-4-0
