Hello Omair, thank you for review. I agree that ReportErrorMessage is better; sorry I didn’t spot this. I also found another misused printf and changed it to ReportErrorMessage as well.
Please see new webrev here: http://cr.openjdk.java.net/~vkarnauk/OPENJDK6-37/webrev.01/ Regards, - Vlad From: Omair Majid<mailto:oma...@redhat.com> Sent: Thursday, July 17, 2014 18:53 To: Vladislav Karnaukhov<mailto:vladis...@azulsystems.com> Cc: jdk6-dev@openjdk.java.net<mailto:jdk6-dev@openjdk.java.net> Hi, * Vladislav Karnaukhov <vladis...@azulsystems.com> [2014-07-17 10:03]: > please review the fix for OPENJDK6-37: OpenJDK6-b32 cannot be built on Windows Sorry for the breakage. > The fix is really simple this time and only affects two files in JDK > workspace. > > webrev: http://cr.openjdk.java.net/~vkarnauk/OPENJDK6-37/webrev.00/ > bug: https://java.net/jira/browse/OPENJDK6-37 For java_md.c, wouldn't it make sense to use `ReportErrorMessage` rather than `printf`? The JDK7 fix calls JLI_ReportErrorMessage, which shows a message box and the JDK6 ReportErrorMessage function looks like it does the same thing. Looks good to me otherwise. Thanks for fixing this! Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
