----- Original Message ----- > On 02/01/15 19:18, Andrew Hughes wrote: > > The result built fine, which is more than can be said for current OpenJDK > > 6, > > in a post-2014-12-31 world ;) > > > > Ok to push? > > That's a lot more than I was expecting! We're surely going to have to > import this, but how can we raise confidence it won't break anything? >
Sadly, it's been building up for years; the first of these changes dates back to 2008. The list looks scary at first glance, but most of the changes boil down to fixing a handful of property values and adding a test case for them. All the changes are to property files or tests. Many of the changes have been in OpenJDK 7 for years and, arguably, things are a lot more broken already if you live in one of the locales where OpenJDK is reporting the wrong currency, date format, etc. The diffstat is as follows: new/make/java/util/FILES_properties.gmk | 3 new/make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java | 4 new/src/share/classes/java/util/CurrencyData.properties | 60 new/src/share/classes/java/util/LocaleISOData.java | 10 new/src/share/classes/sun/text/resources/FormatData_be.java | 4 new/src/share/classes/sun/text/resources/FormatData_et.java | 48 new/src/share/classes/sun/text/resources/FormatData_hr_HR.java | 13 new/src/share/classes/sun/text/resources/FormatData_sl.java | 4 new/src/share/classes/sun/text/resources/FormatData_sv_SE.java | 2 new/src/share/classes/sun/text/resources/FormatData_uk.java | 2 new/src/share/classes/sun/util/resources/CalendarData_hu.properties | 2 new/src/share/classes/sun/util/resources/CalendarData_sl.properties | 6 new/src/share/classes/sun/util/resources/CurrencyNames.properties | 267 + new/src/share/classes/sun/util/resources/CurrencyNames_de.properties | 176 - new/src/share/classes/sun/util/resources/CurrencyNames_es.properties | 108 new/src/share/classes/sun/util/resources/CurrencyNames_es_CU.properties | 67 new/src/share/classes/sun/util/resources/CurrencyNames_es_PE.properties | 2 new/src/share/classes/sun/util/resources/CurrencyNames_es_VE.properties | 2 new/src/share/classes/sun/util/resources/CurrencyNames_et_EE.properties | 55 new/src/share/classes/sun/util/resources/CurrencyNames_fr.properties | 292 + new/src/share/classes/sun/util/resources/CurrencyNames_it.properties | 104 new/src/share/classes/sun/util/resources/CurrencyNames_ja.properties | 110 new/src/share/classes/sun/util/resources/CurrencyNames_ko.properties | 135 new/src/share/classes/sun/util/resources/CurrencyNames_lt_LT.properties | 1 new/src/share/classes/sun/util/resources/CurrencyNames_lv_LV.properties | 1 new/src/share/classes/sun/util/resources/CurrencyNames_pt.properties | 278 + new/src/share/classes/sun/util/resources/CurrencyNames_sk_SK.properties | 54 new/src/share/classes/sun/util/resources/CurrencyNames_sr_RS.properties | 66 new/src/share/classes/sun/util/resources/CurrencyNames_sv.properties | 457 +-- new/src/share/classes/sun/util/resources/CurrencyNames_tr_TR.properties | 2 new/src/share/classes/sun/util/resources/CurrencyNames_uk_UA.properties | 2 new/src/share/classes/sun/util/resources/CurrencyNames_zh_CN.properties | 110 new/src/share/classes/sun/util/resources/CurrencyNames_zh_TW.properties | 178 - new/src/share/classes/sun/util/resources/LocaleNames.properties | 8 new/src/share/classes/sun/util/resources/LocaleNames_es.properties | 120 new/src/share/classes/sun/util/resources/LocaleNames_nl.properties | 426 ++ new/src/share/classes/sun/util/resources/LocaleNames_sv.properties | 2 new/src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java | 3 new/test/java/util/Currency/ValidateISO4217.java | 8 new/test/java/util/Currency/tablea1.txt | 42 new/test/java/util/Locale/LocaleTest.java | 11 new/test/sun/text/resources/LocaleData | 1484 +++++++++- new/test/sun/text/resources/LocaleDataTest.java | 16 43 files changed, 3753 insertions(+), 992 deletions(-) Most of the additions come from gaining localisation data for es_CU, pt and sr_RS, and adding test cases (notably http://cr.openjdk.java.net/~andrew/openjdk6/currency/webrev.01/test/sun/text/resources/LocaleData.patch ) a > Andrew. > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
