* Andrew Hughes <gnu.and...@redhat.com> [2015-01-20 23:06]: > Webrevs for the new changes: > > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/root/ > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/corba/ > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/jaxp/ > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/jaxws/ > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/hotspot/ > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/jdk/ > http://cr.openjdk.java.net/~andrew/openjdk6/20150120/langtools/
I looked over the changes and compared them to the jdk7u changesets that were pushed. The changes for TLS support look very invasive, but look correct to me - I am not familiar with the technical details at all, however. I noticed a few minor issues but I see that there are already bugs filed to fix those. Just one nit: This hunk appears in the fix for 4873188 in jdk7u's test/sun/security/pkcs11/sslecc/CipherTest.java but is missing here: - if ((args.length > 0) && args[0].equals("sh")) { + if ((args != null) && (args.length > 0) && args[0].equals("sh")) { Feel free to fix this in a later changeset. Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681