Hello Omair,

Am 09.03.2015 um 15:19 schrieb Omair Majid:
* Jacob Wisor <gi...@gmx.de> [2015-03-06 09:49]:
Anyways, please review this patch.

Hi Jacob,

Please familiarize yourself with how fixes are added to older versions
of OpenJDK:
http://openjdk.java.net/projects/jdk8u/groundrules.html

In other words, please rebase this patch against jdk9 and get it
committed there first. Then you can start looking into backports.

Okay, thank you for the heads up. I will do take a look into committing to JDK 9 first. However, I was hesitant to do so because it has an utterly different structure than previous JDKs and it looks like a lot of work to get through it. So, I was actually silently hoping that one of you more experienced OpenJDK guys could "forwardport" this patch on behalf of me. Anyways, thank you for being patient with me.

As for 6, I am not sure this patch is applicable. To quote
http://mail.openjdk.java.net/pipermail/jdk6-dev/2013-March/002890.html:

OpenJDK 6 is a legacy project.  People only use it because they want
long-term stability and compatibility.  Therefore, only changes that
fix significant bugs should be made.  This is not a policy change from
that discussed on http://openjdk.java.net/projects/jdk6/

I understand. It has been pointed out to me that this patch may be "incompatible" to jdk8u either because some folks may be parsing the jar tool's output and thus be relying on the exact formatting of the date and time fields. Nevertheless, I would like to see this patch applied to OpenJDK in one form or the other because the jar tool's output in this case should have always been locale specific. If parsing is /really/ an issue then the jar tool should have an additional option to print date and time in ISO format and/or people should migrate their reliant software to explicitly set the locale they are most comfortable with parsing. AFAICT, there does not exist an "ISO" locale. Closest to that is probably some POSIX locale but I might be wrong.

Regards,

Jacob

Reply via email to