----- Original Message ----- > Looks good to me from a code review perspective. I don't know > the rules for approvals to push to jdk 6-open anymore .. >
An approval from an OpenJDK 6 reviewer, such as yourself, is sufficient. Pushed: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c4ed64237075 > -phil. > > On 04/01/2015 07:17 AM, Andrew Hughes wrote: > > Webrev: http://cr.openjdk.java.net/~andrew/openjdk6/8020190/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8020190 > > > > Java_sun_font_FreetypeFontScaler_disposeNativeScaler() passes the scaler > > rather than the font as the second argument to setupFTContext. > > > > Ok to push? > > > > Thanks, > > Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07