Thanks for the reviews! Updated webrevs with all comments...
http://cr.openjdk.java.net/~jmelvin/7130404/hotspot/webrev.01 http://cr.openjdk.java.net/~jmelvin/7130404/jdk/webrev.01 http://cr.openjdk.java.net/~jmelvin/7130404/corba/webrev.01 Main changes were to refine the use of string compares for Mac OS X... < osName.startsWith("Mac OS") > osName.contains("OS X") Any final comments? A decision has not yet been made to include this change or not. I'll provide an update when there's progress. - Jim On 2/20/12 4:02 PM, James Melvin wrote:
Hi, To maintain compatibility with Apple JDKs, a proposal will be made to change the 'os.arch' system property from 'amd64' to 'x86_64' on Mac OS X. Minor changes are required to the following repositories, for which I've provided webrevs... WEBREV: http://cr.openjdk.java.net/~jmelvin/7130404/hotspot/webrev.00 http://cr.openjdk.java.net/~jmelvin/7130404/jdk/webrev.00 TESTING: JPRT job (2012-02-20-203901.jmelvin.hotspot) Notepad, SwingSet2, SPECjbb2005 This change will also impact a small number of internal tests and RE scripts. The bundle names will also reflect the change amd64 -> x86_64. HotSpot changes can be integrated first, with the JDK changes in the following promotion. Should the proposal be rejected for 7u4, I obviously withdraw the bugfix. Feedback welcome, Jim
