On 8/2/11 11:28 PM, Poonam Bajaj wrote:
> Hi Dalibor,
>
> On 8/3/2011 8:33 AM, Dalibor Topic wrote:
>> On 7/14/11 7:00 AM, David Holmes wrote:
>>
>>> Hi Dalibor,
>>>
>>> On 14/07/2011 11:45 AM, Dalibor Topic wrote:
>>>
>>>> Next item on my draft list is code review. The proposal below is inspired
>>>> by the developer guide section on code review, and in part inspired by the
>>>> processes in OpenJDK 6. It tries to encourage transparency, and getting
>>>> more eyes on the code, while at the same time allowing established
>>>> practices, like asking component leads for additional reviews, to continue
>>>> to work.
>>>>
>>>> Public code review:
>>>>
>>>> Preamble: The new infrastructure is not ready yet, so we won't switch to
>>>> it for the next release in OpenJDK (i.e. 7u2, as 7u1 is a CPU) just yet.
>>>> The process here may change for 7u4.
>>>>
>>>> Pre-requisite: Before asking for code review, make sure your fix is
>>>> applied on the most recent revision of the code you intend to work on,
>>>> that there are no build errors on the supported platforms for the release
>>>> you're working on, and that any included or otherwise applicable tests
>>>> pass without failures on all relevant platforms. If you're not able to
>>>> build or test on all supported platforms, you MUST let the reviewers know
>>>> which ones you were able to build and test on, as well as whether you
>>>> anticipate any issues on the platforms you haven't been able to build and
>>>> test on.
>>>>
>>>> Rule 0: Code reviews for public JDK 7 Update forests MUST be done
>>>> publicly: Either through e-mail on jdk7u-dev@openjdk.java.net mailing
>>>> list, or using some other suitable public mechanism. If a code review is
>>>> not done on the jdk7u-dev@openjdk.java.net mailing list, as part of the
>>>> approval request for inclusion of the fix into a public JDK 7 Updates
>>>> forest, which you MUST send to the jdk7u-dev@openjdk.java.net mailing
>>>> list, a URL for the public code review MUST be provided.
>>>>
>>> At present who comprises the set of authors, commiters and reviewers for
>>> the jdk7u project?
>>>
>>
>> The initial set of committers is the set of individuals who have committed
>> code into JDK 7,
>> i.e. the output of
>>
>> for i in . corba/ hotspot/ jaxp jaxws/ jdk/ langtools/ ; do hg -R $i log
>> --template "{author}\n" ; done | sort | uniq
>>
>> on jdk7.
>>
>> The initial set of reviewers is the set of individuals who have reviewed
>> code committed into JDK 7, i.e. are mentioned in a Reviewed-by: line in a
>> commit.
>> I don't have a nice one liner for that yet, though.
>>
>> The initial set of authors is the set of individuals who have submitted code
>> into JDK 7, without having committed it themselves,
>> i.e. the individuals mentioned in Contributed-by lines who are not
>> Committers. Again, no sweet one liner for that either,
>> contributions welcome.
>>
>> The rationale for going with that broad set of individuals is that if you
>> helped create or review changesets for JDK 7, you can now
>> help in the same roles with the updates.
>>
>>
> Can we have a page listing the names of authors, commiters and reviewers for
> jdk7u project ?
http://openjdk.java.net/census/#jdk7u
You'll note that this isn't quite what I described above, but it has the
advantage of being a consistent
transition step across all OpenJDK Projects, rather then having this Project be
a special exception. Since
I expect the vast majority of fixes for JDK 7 Updates to come from JDK 8,
transitioning jdk7u and jdk8 in
the same way makes it in particular a bit easier for fixes to continue to flow
from there to here as quickly
as they have so far.
See http://openjdk.java.net/census/ for more information on the OpenJDK Census.
I have updated the Project web page accordingly with a pointer to the Census.
cheers,
dalibor topic
--
Oracle <http://www.oracle.com>
Dalibor Topic | Java F/OSS Ambassador
Phone: +494023646738 <tel:+494023646738> | Mobile: +491772664192
<tel:+491772664192>
Oracle Java Platform Group
ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
