On 9/16/11 3:08 AM, Dalibor Topic wrote:
On 9/15/11 11:28 PM, Daniel D. Daugherty wrote:
Dalibor and Edvard,
Here is the contingent review request for the hotspot repo part
of Full Debug Symbols Phase 1.
Again, the reason that I'm considering this to be a contingent
request is that I don't have "go" from the VM/SQE team nor from
the Program Management folks.
I'm not familiar with the concept of contingent approval requests.
Could you elaborate on why this change can't go in via the the next
HS22 bulk integration?
If the fix gets approved, it will go in via the next HSX22 bulk
integration request. I've attached two more messages that will
hopefully fill in the blanks.
Dan
cheers,
dalibor topic
--- Begin Message ---
Dalibor and Edvard,
I don't if you remember the Full Debug Symbols project that I mumbled
about back on August 2... Phase 1 of that project will hopefully be
coming up to JDK7u2 via the next HSX-22 push. Oracle's VM/SQE group
is analyzing the performance impact of the changes and hopes to be
done soon.
Phase 1 of the Full Debug Symbols project will consistent of pushes
to three repos: hotspot, install and jdk. Since the install repo is
on the closed side, I'll send that review request along privately.
I've had the changes reviewed internally and this review request is
just for the JDK changes that enable the JDK to import .debuginfo
files from the hotspot repo. The reason that I'm considering this
to be a contingent request is that I don't have "go" from the VM/SQE
team nor from the Program Management folks.
Here's a pointer to the jdk webrev:
http://cr.openjdk.java.net/~dcubed/7085944-webrev/1/
Please note that these changes can't be pushed until after a hotspot
that creates .debuginfo files has been pushed.
Thanks, in advance, for any review and contingent approval.
Dan
--- End Message ---
--- Begin Message ---
On 9/15/11 5:33 PM, David Holmes wrote:
<off-list>
Dan,
I'm confused by this request. This code is already in hs22 or soon
will be - right?
Soon. Hopefully...
When hs22 is ready for the next merge with 7u2 there will be a "bulk
update" request for all updates since the last merge. There is no need
for individual review/approval requests as I understand it.
Yes, this request is not strictly necessary.
This is just part of the review requests that I sent out for FDS.
The fact that the HotSpot changes will come via the next HSX-22 push
was called out in the JDK review request which was the first one that
I sent out. I didn't want to repeat myself too much so I did shorter
messages for the next two...
Dan
Cheers,
David
On 16/09/2011 7:28 AM, Daniel D. Daugherty wrote:
Dalibor and Edvard,
Here is the contingent review request for the hotspot repo part
of Full Debug Symbols Phase 1.
Again, the reason that I'm considering this to be a contingent
request is that I don't have "go" from the VM/SQE team nor from
the Program Management folks.
Here's a pointer to the jdk webrev:
http://cr.openjdk.java.net/~dcubed/7071904-webrev/1/
These changes have to be pushed before the jdk repo changes and
will hopefully come up via the next HSX-22 push...
Thanks, in advance, for any review and contingent approval.
Dan
--- End Message ---