Excellent, then it is [APPROVED]
cheers, dalibor topic On 1/25/12 5:22 PM, Jonathan Gibbons wrote: > Dalibor, > > No, this is an internal method in javac we are talking about. No CCC is > required. > > -- Jon > > > On 01/25/2012 05:03 PM, Dalibor Topic wrote: >> Would this be adding a new public API to JDK 7, i.e. need to go through CCC? >> >> cheers, >> dalibor topic >> >> On 1/25/12 10:29 AM, Jim Holmlund wrote: >>> Here is the bug: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7126832 >>> >>> Here is the webrev >>> http://cr.openjdk.java.net/~jjh/7126832/ >>> >>> The fix is the same as the fix in jdk8 with one exception: >>> - in JDK 8, the compile(...) methods in Main.java return Result whereas in >>> JDK 7 they return int >>> - the patch adds a new compile method, so in 8 this new method is >>> public Result compile(String[] args, ..... >>> >>> whereas in 7u-dev, it is >>> public int compile(String[] args, ..... >>> >>> Here is the patch in jdk 8: >>> http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac36176b7de0 >>> >>> Testing: >>> - langtools built and regression tests run on Windows >>> >>> Thanks >>> - jjh >>> >>> >> > -- Oracle <http://www.oracle.com> Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 <tel:+494023646738> | Mobile: +491772664192 <tel:+491772664192> Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment