Jim, You are good to go! Approved. Cheers, Edvard
On Jan 26, 2012, at 12:44 AM, Jonathan Gibbons wrote: > Looks good to me. > > -- Jon > > On 01/25/2012 12:36 PM, Jim Holmlund wrote: >> Here is the bug: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129225 >> >> Here is the webrev >> http://cr.openjdk.java.net/~jjh/7129225.7u >> >> The jdk8 fix for 7129225 failed when run with jtreg -samevm. The fix for >> 7133314 fixes this problem. >> The bad fix for 7129225 was not pushed to jdk7u. So this 7u fix for 7129225 >> combines the two fixes from JDK 8. >> >> >> Here are the two patches in jdk8: >> http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d16b464e742c >> http://hg.openjdk.java.net/jdk8/tl/langtools/rev/332dfa0f91df >> >> These two patches were approved by Jon Gibbons. >> >> Testing: >> - langtools built and regression tests run on Windows with/without -samevm >> >> Thanks >> - jjh >> >
