On Jun 9, 2012, at 8:32 PM, Daniel D. Daugherty wrote: > > > On 6/9/12 4:50 AM, David Holmes wrote: >> On 9/06/2012 9:25 AM, Daniel D. Daugherty wrote: >>> On 6/7/12 7:01 PM, David Holmes wrote: >>>> This is a simple fix that only applies to 7u and is targeted for 7u6. >>>> >>>> We need to update the embedded image target in Release-embedded.gmk to >>>> remove the FDS related files that now get created. This obviously only >>>> impacts embedded builds. >>>> >>>> http://cr.openjdk.java.net/~dholmes/7175331/webrev/ >>>> >>>> Also tidied up some extraneous -f options on rm ($(RM) == rm -f) >>> >>> line 168: -type f -name "*.debuginfo" -o -name "*.diz" -print >>> I think this part needs to be: >>> >>> -type f \( -name "*.debuginfo" -o -name "*.diz" \) -print >>> >>> so that the '-o' option binds correctly. >> >> Thanks Dan you are right. It's not likely that there would be a *.diz >> directory but better to get this right. I've updated the webrev for >> completeness: >> >> http://cr.openjdk.java.net/~dholmes/7175331/webrev.01/ >> >> but will assume your reviews stands, as does Kelly's. I have to request >> approval to push anyway. > > Yes, my review still stands.
Mine too. -kto > > Dan > >> >> Thanks, >> David >> >>> Dan >>>
