Hi Charles,
Could you please explain, why your fix contains only motif.properties,
but doesn't contain changes for other languages?
I also didn't catch why other properties files (like windows.properties)
shouldn't backported as well
Thanks, Pavel
On 07/23/2012 08:01 PM, Pavel Porvatov wrote:
Hi Charles,
On 07/18/2012 05:30 PM, Pavel Porvatov wrote:
Hi Charles,
Hi all,
Requesting for approval to push the changes to add mnemonic for
JFileChooser metal and motif Laf
Changeset for jdk8 @
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fbc8d86c477
Changeset for jdk7u-dev @
http://cr.openjdk.java.net/~littlee/jdk7u/197/webrev.00/
<http://cr.openjdk.java.net/%7Elittlee/jdk7u/197/webrev.00/>
Please notice that, changeset for jdk7u-dev is part of the
changeset for jdk8, because "CR 7093156 - NLS: Please change the
mnemonic assignment system to avoid translation issue" has already
been committed in jdk7u-dev (jdk7u6)[1].
I'm observing that
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fbc8d86c477 has
motif*.properties changes, but [1] doesn't have that changes. It
seems your fix is not completed, because now in jdk8 file
motif.properties (and others) contains
FileChooser.pathLabel.textAndMnemonic=Enter &path or folder name:
but jdk7u-dev contains
FileChooser.pathLabel.textAndMnemonic=Enter path or folder name:
Could you please clarify that? Which tests have you passed with the
fix?
I'm also not sure that we want backport P4 bugs into 7u8. Do you
have any justification for that?
Regards, Pavel
Reviewed by:
Alexander Potochkin
[1]:
http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/003003.html
Hi Pavel,
You are right. I was thought it was part of the "CR 7093156 - NLS:
Please change the mnemonic assignment system to avoid translation
issue". It was part of "CR 7093156" in jdk8.
I have upload a new webrev @
http://cr.openjdk.java.net/~littlee/jdk7u/197/webrev.02/
<http://cr.openjdk.java.net/%7Elittlee/jdk7u/197/webrev.01/> . Would
you please help to review it?
I didn't catch which webrev is correct? The text correspondent to
webrev.02, but link point to webrev.01...
What is P4/P5 bugs? Any place I can refer to ?
P4/P5 is priority of bugs. E.g.
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024118 has
priority 4-Low...
Regards, Pavel
Hi Pavel,
It seems my thunderbird is not WYSIWYG.
Please help to review webrev @
http://cr.openjdk.java.net/~littlee/jdk7u/197/webrev.03/
<http://cr.openjdk.java.net/%7Elittlee/jdk7u/197/webrev.03/>
--
Yours Charles
