----- Original Message ----- > Hi all, > > This is a request to backport some RMI warnings fixes. I'm not > actually very > concerned with warnings in 7u. This is really about making the RMI > source code > in 7u and 8 more consistent. In backporting other changes, I've found > that the > warnings fixes generate conflicts, and in general they make the diffs > confusing > to read. > > The story with the three changesets is that the first changeset broke > some > things in rmic, the second reverted those specific changes, and the > third > applies the fixed changes. > > The three patches applied cleanly, without modification. I ran a > build with > SKIP_BOOT_CYCLE=false and it completed successfully and passed all > tests. Er, > the number of test failures was unchanged relative to recent 7u12 > builds. :-/ > > The three changesets from JDK8 are as follows: > > http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/8f61ac5986ee > http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ce6b852bf4e2 > http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/337d4570b8d6 > > changeset: 5085:8f61ac5986ee > user: khazra > date: Fri Mar 02 13:48:43 2012 -0800 > summary: 7146763: Warnings cleanup in the sun.rmi and related > packages > > changeset: 5090:ce6b852bf4e2 > user: khazra > date: Mon Mar 05 17:38:01 2012 -0800 > summary: 7151348: Build breaks due to warning clean up in > sun.rmi.*(7146763) > > changeset: 5142:337d4570b8d6 > user: khazra > date: Fri Mar 16 11:52:48 2012 -0700 > summary: 7152007: Fix warnings in sun/rmi/rmic > > Review email threads are as follows: > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-February/009315.html > http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-March/009423.html > http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-March/009476.html > http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-March/009589.html > > Links to bugs are: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146763 > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151348 > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7152007 > > Thanks, > > s'marks >
I was surprised to see these being backported. I can follow the reasoning for doing so, but we must be careful of introducing unwanted behaviour changes through a fix which isn't really required in a maintenance release. I'm not thinking so much of the <> operator but this change also moves to use try-with-resources. While the new behaviour may be more correct, it's still may be a change from what was there before. Just an FYI, Thanks, -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
