Hello,
Please review a fix for the issue:
8014721: TEST_BUG:
java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with
java.lang.UnsupportedOperationException
http://bugs.sun.com/view_bug.do?bug_id=8014721
The webrev is: http://cr.openjdk.java.net/~kshefov/8014721/webrev.00/
Direct backport from jdk 8
Reviews for jdk 8 attached.
Thanks,
Konstantin
--- Begin Message ---
Looks great. Thank you.
--
best regards,
Anthony
On 05/17/2013 01:45 PM, Konstantin Shefov wrote:
Thanks for reviewing,
new webrev is http://cr.openjdk.java.net/~kshefov/8014721/webrev.01
On 17-May-13 13:43, Anthony Petrov wrote:
Thanks. With such a change I'm fine with the fix.
--
best regards,
Anthony
On 05/17/2013 01:38 PM, Konstantin Shefov wrote:
On 17-May-13 13:20, Anthony Petrov wrote:
Hi Konstantin,
Did you run the test after your modification? I believe it should now
fail with an NPE.
NO NPE is thrown, because SystemTray.isSupported is static method.
But I will correct the test by replacing tray.isSupported(); to
SystemTray.isSupported();
--
best regards,
Anthony
On 05/16/2013 02:19 PM, Konstantin Shefov wrote:
Hello,
Please review a fix for the issue:
8014721 TEST_BUG:
java/awt/TrayIcon/DragEventSource/DragEventSource.java
fails with java.lang.UnsupportedOperationException
http://bugs.sun.com/view_bug.do?bug_id=8014721
The webrev is: http://cr.openjdk.java.net/~kshefov/8014721/webrev.00/
Thanks,
Konstantin
--- End Message ---
--- Begin Message ---
Hi, Konstantin.
Fix looks good.
On 16.05.2013 14:19, Konstantin Shefov wrote:
Hello,
Please review a fix for the issue:
8014721 TEST_BUG:
java/awt/TrayIcon/DragEventSource/DragEventSource.java fails with
java.lang.UnsupportedOperationException
http://bugs.sun.com/view_bug.do?bug_id=8014721
The webrev is: http://cr.openjdk.java.net/~kshefov/8014721/webrev.00/
Thanks,
Konstantin
--
Best regards, Sergey.
--- End Message ---
