On 5/24/13 11:43 AM, Staffan Larsen wrote: > A retroactive request for approval for the following review: > > http://mail.openjdk.java.net/pipermail/jdk7u-dev/2013-May/006471.html
Thanks for catching this so quickly, Staffan & for taking care of approving it, Sean. Just a few small items from my side: A point on semantics: you don't need an approval to run a review for some change destined for 7u or other (and it may very well turn out during review that the proposed change is not as desirable as initially thought, for example), but you do need an approval for a *push* to a 7u forest. A point on order: Please use the template at http://openjdk.java.net/projects/jdk7u/approval-template.html in the future. A point on sanity checking: The change you actually pushed at http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c4788be627ad says "Use open man pages for non commercial builds", which sounds fair enough. Your request uses a flag that doesn't exist in the OpenJDK 7u forest - it's less confusing if you go with what you have pushed. thanks, dalibor topic -- Oracle <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
