On 6/21/13 6:44 PM, Phil Race wrote: > Historically the SE client areas (swing/awt/2d) have required 2 reviewers > for everything that's a significant change. > test, doc, trivial fixes can have one reviewer.
Yeah, I can see in that case the maintainer approving the fix acting as the additional, second Reviewer, assuming they have that role in jdk7u. >> in that case, I'd suggest that we go for the stricter interpretation, and >> require two jdk7u reviewers. > > BTW this could mean that the original 8 fix which is back ported may need > additional review. Yes. Do you think that would be challenging in general? cheers, dalibor topic > -phil. > > On 6/21/2013 1:09 AM, Dalibor Topic wrote: >> On 6/19/13 1:21 PM, Jim Laskey (Oracle) wrote: >>> Just want to pipe in on 'challenge'. The five person Nashorn team adopted >>> a two reviewer policy from the start. The feeling was that it kept team >>> members abreast of what was 'going on' as much as adding more critical >>> review. It gets tough at vacation time, but we've made it work (with few >>> thin herd/one liner/one reviewer occurrences.) >> Thanks, Jim - in that case, I'd suggest that we go for the stricter >> interpretation, and require two jdk7u reviewers. >> >> cheers, >> dalibor topic >> >>> Cheers, >>> >>> -- Jim >>> >>> >>> On 2013-06-19, at 7:44 AM, Alan Bateman <[email protected]> wrote: >>> >>>> On 19/06/2013 10:52, Dalibor Topic wrote: >>>>> : >>>>> They should both have the Reviewer role. >>>>> >>>>> Would changing "At least two reviewers are required for phase 2." in >>>>> http://openjdk.java.net/projects/jdk7u/phase2/phase2-approval-template.html >>>>> to "At least two reviewers, from the set of Reviewers listed on the JDK 7 >>>>> Update census page [0] are required for phase 2." make it clear? If so, >>>>> I'll formally propose it for discussion later today. >>>>> >>>>> [0] http://openjdk.java.net/census#jdk7u >>>> Thanks for getting the clarification on this moving. >>>> >>>> The only thing I will say is that for some areas (niche areas in >>>> particular) that having two reviewers with reviewer role on the jdk7u >>>> project might be challenge. One thing to consider is whether it might make >>>> sense to relax it a bit to allow one of the reviewers be someone with >>>> reviewer role on the jdk8 project. >>>> >>>> -Alan. >> >> > -- Oracle <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
