Hi Dalibor! See inline.
Best regards,
Alexey Zhebel
On 18.07.2013 17:24, Dalibor Topic wrote:
On 7/18/13 12:46 PM, alexey zhebel wrote:
Thanks to Mikael, Joe, and Stuart for the previous reviews and feedback!
We generated the fixed versions of the two man pages (java and jcmd). The
copyright and license text has been corrected and several formatting issues
have been fixed. Due to constraints within the tool chain and release
deadlines, other remaining issues will be discussed and resolved later.
Please review the pages.
The webrev is located here:
http://cr.openjdk.java.net/~azhebel/8016767/
And here is the bug if you need it:
https://jbs.oracle.com/bugs/browse/JDK-8016767
Thanks for posting the changes for review, Alexey, and addressing most of the
issues raised in the previous round of feedback.
The content changes look fine for the most part to me, and I appreciate the
effort to clean up acronyms, and terminology.
Looking at
http://cr.openjdk.java.net/~azhebel/8016767/webrev/src/linux/doc/man/java.1.udiff.html
I found two bits that jumped out:
\-client
-Select the Java HotSpot Client VM.
+Selects the Java HotSpot VM client.
\-server
-Select the Java HotSpot Server VM.
+Selects the Java HotSpot VM server.
What's the reason for that change?
There was some confusion in terminology, but according to /java
-version/, it was correct in the first place. This will be fixed in the
man pages for JDK 8. So will the typo below.
\-showversion
-Display version information and continue. (See also \f3\-version\fP.)
+Displays version information and continue.
-Display version information and exit. (See also \f3\-showversion\fP.)
+Displays version information and exit. See also the \f3\-showversion\fP option.
I assume these should be 'continues' and 'exits' to follow along with the move
to 'Displays'?
cheers,
dalibor topic
