Hello,

Please approve a direct backport from jdk 8:

8015599 [TEST_BUG] [macosx] Test closed/javax/swing/Popup/TaskbarPositionTest.java fails since JDK 8 b75 on MacOSX

Test bug fix. Move from closed repo.

Reviewed-by: alexsch, serb (attached).

http://bugs.sun.com/view_bug.do?bug_id=8015599

The webrev is: http://cr.openjdk.java.net/~kshefov/8015599/webrev.01 - add to open repo. http://cr.openjdk.java.net/~kshefov/8015599/webrev.diff - diff with previous version of the test.

Thanks,
Konstantin
--- Begin Message ---
Hi, Konstantin.
The fix looks good.

On 24.09.2013 13:13, Konstantin Shefov wrote:

On 23-Sep-13 16:06, Konstantin Shefov wrote:
Please, review new version
http://cr.openjdk.java.net/~kshefov/8015599/webrev.01

On 13-Sep-13 16:38, Alexander Scherbatiy wrote:

Could you also move the TaskbarPositionTest creation on EDT? There can be intermittent fails because of the race conditions.

   Thanks,
   Alexandr.


On 9/13/2013 4:06 PM, Konstantin Shefov wrote:
Hello,

Please review a fix for the issue:

8015599 [TEST_BUG] [macosx] Test closed/javax/swing/Popup/TaskbarPositionTest.java fails since JDK 8 b75 on MacOSX

Test bug fix. Move from closed repo.

http://bugs.sun.com/view_bug.do?bug_id=8015599

The webrev is: http://cr.openjdk.java.net/~kshefov/8015599/webrev.00 - add to open repo. http://cr.openjdk.java.net/~kshefov/8015599/webrev.diff - diff with previous version of the test.

Thanks,
Konstantin





--
Best regards, Sergey.


--- End Message ---
--- Begin Message ---

  The fix looks good for me.

  Thanks,
  Alexandr.


On 9/23/2013 4:06 PM, Konstantin Shefov wrote:
Please, review new version
http://cr.openjdk.java.net/~kshefov/8015599/webrev.01

On 13-Sep-13 16:38, Alexander Scherbatiy wrote:

Could you also move the TaskbarPositionTest creation on EDT? There can be intermittent fails because of the race conditions.

   Thanks,
   Alexandr.


On 9/13/2013 4:06 PM, Konstantin Shefov wrote:
Hello,

Please review a fix for the issue:

8015599 [TEST_BUG] [macosx] Test closed/javax/swing/Popup/TaskbarPositionTest.java fails since JDK 8 b75 on MacOSX

Test bug fix. Move from closed repo.

http://bugs.sun.com/view_bug.do?bug_id=8015599

The webrev is: http://cr.openjdk.java.net/~kshefov/8015599/webrev.00 - add to open repo. http://cr.openjdk.java.net/~kshefov/8015599/webrev.diff - diff with previous version of the test.

Thanks,
Konstantin




--- End Message ---

Reply via email to