Thanks, Sean, this looks fine to me - approved for jdk7u-dev. cheers, dalibor topic
----- Ursprüngliche Mail ----- Von: sean.cof...@oracle.com An: sundararajan.athijegannat...@oracle.com, jdk7u-dev@openjdk.java.net Gesendet: Mittwoch, 25. Dezember 2013 11:07:00 GMT +01:00 Amsterdam/Berlin/Bern/Rom/Stockholm/Wien Betreff: [7u60] Request for approval : 8022698 [TEST] javax/script/GetInterfaceTest.java fails since 7u45 b04 when run with jtreg -agentvm option This is a testcase fix. 7u45 changes put restrictions in the RhinoScript implementation. This testcase has been failing in jtreg agent mode since then. Fix is trivial and involves making the interface public. Patch pasted below. Already fixed in 7u51 but I'd like to sync to 7u60 now to help testing metrics there. Sundararajan Athijegannathan has reviewed the fix but I'm cc'ing him here so we can have public record. Sundar - please review if possible. bug link : https://bugs.openjdk.java.net/browse/JDK-8022698 regards, Sean. 8022698: javax/script/GetInterfaceTest.java fails since 7u45 b04 with -agentvm option Reviewed-by: sundar --- a/test/javax/script/GetInterfaceTest.java Tue Nov 19 08:37:13 2013 -0800 +++ b/test/javax/script/GetInterfaceTest.java Thu Nov 21 13:39:01 2013 +0000 @@ -67,11 +67,11 @@ public class GetInterfaceTest { foo2.bar2(); } - interface Foo { + public interface Foo { public void bar(); } - interface Foo2 extends Foo { + public interface Foo2 extends Foo { public void bar2(); } } -- Oracle <http://www.oracle.com> Dalibor Topic | Principal Product Manager Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961> Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Geschäftsführer: Jürgen Kunz Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
