Hello,
please approve the backport of the fix to jdk7u-dev.
The bug: https://bugs.openjdk.java.net/browse/JDK-8022531
The JDK 9 changeset:
http://hg.openjdk.java.net/jdk9/client/jdk/rev/3d9d937de317
Reviews attached
Thanks,
Konstantin
--- Begin Message ---
Approved.
Review thread:
http://mail.openjdk.java.net/pipermail/awt-dev/2014-March/007293.html
-Rob
On 21/03/14 12:46, Konstantin Shefov wrote:
Hello,
please approve the backport of the fix to jdk8u-dev.
The bug: https://bugs.openjdk.java.net/browse/JDK-8022531
The JDK 9 changeset:
http://hg.openjdk.java.net/jdk9/client/jdk/rev/3d9d937de317
Thanks,
Konstantin
--- End Message ---
--- Begin Message ---
Hi, Konstantin.
The fix looks fine, but please split your new LONG line. before the push.
On 3/21/14 2:44 PM, Konstantin Shefov wrote:
Thanks for the review, look at the fix
http://cr.openjdk.java.net/~kshefov/8022531/webrev.01/
-Konstantin
On 21.03.2014 14:46, Petr Pchelko wrote:
Hello, Konstanting.
After some discussion I've got a comment: what if some platform
actually have an "OK" button and not "Save"?
Could you please update the fix to say something like: "... and click
a confirmation button (OK, Save or any other platform-dependent name)"
With best regards. Petr.
On 21.03.2014, at 14:31, Konstantin Shefov
<konstantin.she...@oracle.com> wrote:
Hello AWT team,
please review the fix
http://cr.openjdk.java.net/~kshefov/8022531/webrev.00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8022531
It is simple manual test fix.
Thanks
-Konstantin
--
Best regards, Sergey.
--- End Message ---
--- Begin Message ---
Thank you.
Looks good.
With best regards. Petr.
On 21.03.2014, at 14:44, Konstantin Shefov <konstantin.she...@oracle.com> wrote:
> Thanks for the review, look at the fix
> http://cr.openjdk.java.net/~kshefov/8022531/webrev.01/
>
> -Konstantin
>
> On 21.03.2014 14:46, Petr Pchelko wrote:
>> Hello, Konstanting.
>>
>> After some discussion I've got a comment: what if some platform actually
>> have an "OK" button and not "Save"?
>> Could you please update the fix to say something like: "... and click a
>> confirmation button (OK, Save or any other platform-dependent name)"
>>
>> With best regards. Petr.
>>
>> On 21.03.2014, at 14:31, Konstantin Shefov <konstantin.she...@oracle.com>
>> wrote:
>>
>>> Hello AWT team,
>>>
>>> please review the fix
>>> http://cr.openjdk.java.net/~kshefov/8022531/webrev.00/
>>> for the issue
>>> https://bugs.openjdk.java.net/browse/JDK-8022531
>>>
>>> It is simple manual test fix.
>>>
>>> Thanks
>>>
>>> -Konstantin
>
--- End Message ---
