Hi, I'm requesting approval to push a patch for JDK-8041507. The patch has been reviewed by Tim Bell. See more details in the review thread below.
A JPRT 32 and 64 bit Windows build was successful. (The Java Access Bridge is only used for Windows.) Note that a companion patch will also be pushed to closed. That patch is a straight backport from 9. Pete -------- Original Message -------- Subject: Re: Request for review of make changes for JDK-8041507, Java Access Bridge version strings need to be fixed Date: Wed, 23 Apr 2014 16:23:53 +0000 From: Tim Bell <tim.b...@oracle.com> Organization: Java Platform To: peter.bru...@oracle.com CC: build-dev <build-...@openjdk.java.net> Hi Pete: > Please review the open part of the change for this fix: > > JDK-8041507 Java Access Bridge version strings need to be fixed > https://bugs.openjdk.java.net/browse/JDK-8041507 > > Change: > Some variables needed to be set for use by the RC phase of the build of > jabswitch.exe. The closed part of the fix is a straight backport of the > 9 fix and includes use of variables set in the make file. The open part > of the fix for the make changes could not be backported due to build > changes between 7 and 8/9 so a similar change was made to the 7 build > file and can be found in the patch. > > Webrev: > http://cr.openjdk.java.net/~ptbrunet/JDK-8041507/webrev.00/ Looks good to me, as long as test builds on Windows worked as expected. Tim
