On 9/17/14 5:26 AM, Seán Coffey wrote:
1st prize goes to the hotspot team for failing to use noreg- labels!
Please add them.
Yup. Probably has something to do with the fact that historically
most HotSpot regression tests were created using the Tonga test
harness and were handled completely differently than JavaTest/JTREG
tests. However, that is changing and a majority of new HotSpot
regression tests are written using JavaTest/JTREG...
Approved for jdk7u-dev but subject to peer code review.
src/cpu/sparc/vm/stubGenerator_sparc.cpp
Not in the JDK8u version, but I can see why the change is here.
src/os/bsd/vm/os_bsd.cpp
No comments.
src/os/linux/vm/os_linux.cpp
No comments.
src/os/solaris/vm/os_solaris.cpp
No comments.
src/os/windows/vm/os_windows.cpp
No comments.
src/share/vm/runtime/objectMonitor.cpp
Thanks for also backporting this one.
src/share/vm/runtime/os.hpp
No comments.
src/share/vm/runtime/park.cpp
No comments.
src/share/vm/runtime/thread.cpp
No comments.
Thumbs up!
Dan
regards,
Sean.
On 17/09/14 11:49, Sergey Gabdurakhmanov wrote:
Hello,
Could you please approve the back-port of the fix for 8028280 and
8038274 to jdk7u-dev?
Especially please check stubGenerator_sparc.cpp
The bugs:
https://bugs.openjdk.java.net/browse/JDK-8028280
https://bugs.openjdk.java.net/browse/JDK-8038274
The webrev:
http://cr.openjdk.java.net/~sgabdura/8028280/webrev.00/
The review threads:
8028280
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-November/010131.html
8038274
http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-February/012539.html
The jdk8 changeset:
8028280
http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/0e6af9b390af
8038274
http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/8c6165f9ea8e
BR,
Sergey
