Thanks Alan!

On 24.10.2014 12:33, Alan Bateman wrote:
On 24/10/2014 03:52, Ivan Gerasimov wrote:
Thanks Dalibor!

Could someone with the Reviewer status review this please
Skimming through the changes then I don't see any issues, except overly long lines in win32Error which makes it hard to look at the changes side-by-side. It would be nice not to have #ifdef WIN32 in the shared code but that isn't your doing, it's in the original change too.

Yes. I thought it's better to keep it the way it has been formatted in 8.
Do you want me to change this to make lines shorter?

Sincerely yours,
Ivan

Reply via email to