----- Original Message ----- > On Mon, 2016-02-22 at 13:16 -0500, Andrew Hughes wrote: > > > > Also, not sure why you need two URLs here? What is the difference > > > > between > > > > webrev (the one I review) and 'HG export'? > > > > > > Convenience. If you don't use the hg-exports, that's fine by me. Some > > > people prefer that over webrev patches. I didn't mean to confuse > > > people. > > > > Ok, I'm just not sure how they are different; the exported hg patch is > > in the webrev, isn't it? > > It's not for me. At least I can't find it if it's there as you claim. > Example: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8145982/jdk7.00/jdk.patch > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8145982/jdk7-exports/JDK-8145982.export.jdk.patch > > The former is from the webrev. The latter the HG-exported one. The > former does *not* include the commit message and it has this weird diff > context format with "old/new": > > --- old/test/sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java > 2016-02-19 14:31:05.245490870 +0100 > +++ new/test/sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java > 2016-02-19 14:31:05.158492043 +0100 > > Not sure how to convince webrev.ksh to do hg-exports. > > Cheers, > Severin >
Are you using the latest webrev? This is my most recent one, which looks like your export: http://cr.openjdk.java.net/~andrew/aarch64-8/sync/jdk.webrev.01/webrev/jdk.changeset -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
