On 2/2/2012 6:10 AM, Chris Hegarty wrote:
Michael,

I see others have guessed submitting separate code reviews. I can wait till then for a formal review, but here are a few specific comments:

ICC_Profile.java
You can use ICC_Profile as the generic type for the PrivilegedAction rather than Object.

I agree, I was going to say the same, it should be modified as suggested before submitting it to 2d-dev along with the two proposed javax.print changes which also should go to 2d-dev.

-phil.


--- a/src/share/classes/java/awt/color/ICC_Profile.java Sat Jan 28 20:41:27 2012 -0800 +++ b/src/share/classes/java/awt/color/ICC_Profile.java Thu Feb 02 09:56:41 2012 +0000
@@ -921,9 +921,9 @@ public class ICC_Profile implements Seri
      */
     private static ICC_Profile getStandardProfile(final String name) {

-        return (ICC_Profile) AccessController.doPrivileged(
-            new PrivilegedAction() {marino :
-                 public Object run() {
+        return AccessController.doPrivileged(
+            new PrivilegedAction<ICC_Profile>() {
+                 public ICC_Profile run() {
                      ICC_Profile p = null;
                      try {
                          p = getInstance (name);




Reply via email to