On 2/28/12 2:34 AM, Alan Bateman wrote:
On 27/02/2012 23:47, David Holmes wrote:
General meta comment: When this stuff went into 7u my biggest complaint was
that it introduced a mass of new platform-specific stuff in places that
weren't otherwise platform specific. That still seems to be the case. I was
really hoping/expecting that these issues could be resolved before it was
merged with JDK8 otherwise they will never be fixed. Eg
jdk/make/common/Rules.gmk, jdk/make/common/shared/Defs-java.gmk. It seems to
me that many of the specializations could be placed into the
platform-specific gmk file(s) instead of polluting the shared ones. In some
case though (eg Makefiles where we have to change SUBDIR) it indicates we
need a better way to specialize things.
I agree there wasn't as much clean-up done in the jdk7u-dev forest as was hoped
but I think it would be better to do the clean-up and refactoring work that was
suggested in jdk8 rather than as part of the forward-port. The changes could be
back-ported to 7u as appropriate. I also suspect that it's not worth putting
too much effort into cleaning up the make files for jdk8 as they will (we hope)
go away once build-infra takes over.
Another meta comment: this is adding to the technical debt of the project. Not
that this is a bad thing. I understand the urgency of getting JDKs 7 & 8 in
synch and to get Mac builds for JDK8. But, is there a way to track these kinds
of postponed cleanups? I suppose we could file bugs, but they'd probably get
lost among the 2,000 other open bugs.
s'marks
