Hi Everybody.
Looks like on the server we still use jcheck without fix for Objective-C
files? Does anybody know how to apply the fix to jdk8? (see attachment)
[jdk]
pulling from http://hg.openjdk.java.net/jdk8/awt/jdk
searching for changes
adding changesets
adding manifests
adding file changes
added 1 changesets with 10 changes to 10 files
[jcheck 25e85a608db1 2011-07-08 09:19 -0700]
> Changeset: 5305:0fad89bd606b
> Author: alexsch
> Date: 2012-05-02 17:54
>
> 7154048: [macosx] At least drag twice, the toolbar can be dragged to
the left
side
> Reviewed-by: anthony, leonidr
src/macosx/native/sun/awt/AWTView.m:84: Trailing whitespace
src/macosx/native/sun/awt/AWTWindow.m:173: Trailing whitespace
transaction abort!
rollback completed
skipped: pretxnchangegroup.jcheck hook failed
02.05.2012 17:53, alexandr.scherba...@oracle.com wrote
Changeset: 0fad89bd606b
Author: alexsch
Date: 2012-05-02 17:54 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0fad89bd606b
7154048: [macosx] At least drag twice, the toolbar can be dragged to the left
side
Reviewed-by: anthony, leonidr
! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/native/sun/awt/AWTView.h
! src/macosx/native/sun/awt/AWTView.m
! src/macosx/native/sun/awt/AWTWindow.h
! src/macosx/native/sun/awt/AWTWindow.m
+ test/java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java
+ test/java/awt/Mouse/EnterExitEvents/DragWindowTest.java
+ test/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java
! test/java/awt/regtesthelpers/Util.java
--- Begin Message ---
Folks,
The 'official' copy of jcheck is not scanning .m or .mm files for whitespace
violations. I use a local copy of the latest jcheck so I don't have to be on
VPN all the time, and I modified the script to look at .m files as well. Two
change sets just arrived with trailing whitespace.
From what I have been told about mercurial and the way jcheck works, fixing
this is going to be more than a simple script change because jcheck looks at
each changeset as they are applied to your local workspace.
I think I can work around this by relaxing the pretxnchangegroup.jcheck but we
really should investigate this soon.
The jcheck script fix is very easy. Change line 142 to:
normext_re = re.compile(".*\.(java|c|h|cpp|hpp|m|mm)$")
-- Scott K.
----------------------------------------
Scott Kovatch
scott.kova...@oracle.com
Santa Clara/Pleasanton, CA
--- End Message ---
