The (InputStream) cast is not needed, is it?
I've got:
# Java sources to be compiled: (listed in file
/Volumes/data/projects/java/jdk/jdk8/jdk8/build/macosx-x86_64/tmp/.classes.list)
../../../src/share/classes/com/sun/naming/internal/ResourceManager.java
# Running javac: 1 files; in
/Volumes/data/projects/java/jdk/jdk8/jdk8/jdk/make/javax/others
/Library/Java/JavaVirtualMachines/jdk1.7.0_10.jdk/Contents/Home/bin/java
-XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions -XX:-LogVMOutput
-Djava.awt.headless=true -Xmx512m -Xms512m -XX:PermSize=32m
-XX:MaxPermSize=160m
-Xbootclasspath/p:/Volumes/data/projects/java/jdk/jdk8/jdk8/build/macosx-x86_64/langtools/dist/bootstrap/lib/javac.jar
-jar
/Volumes/data/projects/java/jdk/jdk8/jdk8/build/macosx-x86_64/langtools/dist/bootstrap/lib/javac.jar
-Werror -Xlint:all -Xlint:-path -source 8 -target 8 -encoding ascii
-Xbootclasspath:/Volumes/data/projects/java/jdk/jdk8/jdk8/build/macosx-x86_64/classes
-sourcepath
../../../src/closed/solaris/classes:../../../src/closed/share/classes:/Volumes/data/projects/java/jdk/jdk8/jdk8/build/macosx-x86_64/gensrc:::/Volumes/data/projects/java/jdk/jdk8/jdk8/jdk/src/macosx/classes:/Volumes/data/projects/java/jdk/jdk8/jdk8/jdk/src/solaris/classes:/Volumes/data/projects/java/jdk/jdk8/jdk8/jdk/src/share/classes
-d /Volumes/data/projects/java/jdk/jdk8/jdk8/build/macosx-x86_64/classes
@/Volumes/data/projects/java/jdk/jdk8/jdk8/build/macosx-x86_64/tmp/.classes.list.filtered
../../../src/share/classes/com/sun/naming/internal/ResourceManager.java:563:
warning: [cast] redundant cast to InputStream
InputStream istream = (InputStream)resources.next();
^
error: warnings found and -Werror specified
1 error
1 warning
make[4]: *** [.compile.classlist] Error 1
make[3]: *** [all] Error 1
make[2]: *** [all] Error 1
make[1]: *** [jdk-build] Error 2
make: *** [build_product_image] Error 2
Thanks,
Johnny Chen
On Nov 13, 2012, at 11:04 AM, [email protected] wrote:
> Changeset: f51943263267
> Author: andrew
> Date: 2012-11-07 16:07 -0500
> URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f51943263267
>
> 8003120: ResourceManager.getApplicationResources() does not close InputStreams
> Summary: Add finally blocks to close the InputStream instances
> Reviewed-by: lancea
>
> ! src/share/classes/com/sun/naming/internal/ResourceManager.java
