On 04/03/2013 22:52, Mike Duigou wrote:
Hello all;Sorry for the wide broadcast but this change, though very small, affects many different teams. Currently the JDK8 root repo "make test" target runs against the jdk pre-image. ie. the compiled jdk classes. Many tests regression tests expect to be run against a full jdk image and fail. This change causes the j2sdk image to be used instead of the jdk pre-image. Mike diff -r 1ae17ff49fd1 common/makefiles/Main.gmk --- a/common/makefiles/Main.gmk Wed Feb 20 17:56:16 2013 -0800 +++ b/common/makefiles/Main.gmk Mon Mar 04 14:32:57 2013 -0800 @@ -180,7 +180,7 @@ test: start-make @$(call TargetEnter) - @($(CD) $(SRC_ROOT)/test&& $(BUILD_LOG_WRAPPER) $(MAKE) -j1 -k MAKEFLAGS= PRODUCT_HOME=$(OUTPUT_ROOT)/jdk JPRT_JAVA_HOME=$(OUTPUT_ROOT)/jdk ALT_OUTPUTDIR=$(OUTPUT_ROOT) $(TEST)) || true + @($(CD) $(SRC_ROOT)/test&& $(BUILD_LOG_WRAPPER) $(MAKE) -j1 -k MAKEFLAGS= PRODUCT_HOME=$(JDK_IMAGE_DIR) JPRT_JAVA_HOME=$(JDK_IMAGE_DIR) ALT_OUTPUTDIR=$(OUTPUT_ROOT) $(TEST)) || true @$(call TargetExit) # Stores the tips for each repository. This file is be used when constructing the jdk image and can be
This looks okay to me and it make sense to default to the JDK image. -Alan
