On 4/12/2013 10:24 AM, Alejandro E Murillo wrote:

minor one,  change the year to 2013 on this:
http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/make/bsd/makefiles/fastdebug.make.cdiff.html

The files were flagged for their inconsistent format, no analysis was done as to the correctness of the years, as that's a separate process.

But for the file you mention, the year is correct, since the last meaningful change was Dec 14, 2012.

Adding a comma after a year in a GPL header isn't considered a change worth bumping up the year.

    Thanks
            Dave


On 4/12/2013 10:06 AM, David Katleman wrote:
Below are corrections to GPL headers found in JDK8 b85:

http://cr.openjdk.java.net/~katleman/8012048/webrev.hotspot.01/
    http://cr.openjdk.java.net/~katleman/8012048/webrev.jdk.01/
http://cr.openjdk.java.net/~katleman/8012048/webrev.langtools.01/
http://cr.openjdk.java.net/~katleman/8012048/webrev.nashorn.01/
    http://cr.openjdk.java.net/~katleman/8012048/webrev.root.01/

Most are simple punctuation changes.

As a veteran of many such header reviews, reviewing the patch link at the top of the webrev is often easier than each individual file.

    Thanks
    Dave




Reply via email to