vote: yes - jjh On 8/27/2013 5:45 PM, Jonathan Gibbons wrote:
I hereby nominate Joel Borggrén-Franck to jdk8 Reviewer.Joel has been an active participant in JDK 8 since joining the LangTools team over a year ago, as can be seen by his numerous contributions to the langtools, jdk and hotspot repos [below] in the areas of annotations and reflection.Votes are due by Sep 10, 2013, 18:00 PDT.Only current jdk8 Reviewers[1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list.For Three-Vote Consensus voting instructions, see [2]. -Alan. [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#reviewer-vote ----------------------------- *** hotspot changeset: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/a589c78a8811 8014709: Constructor.getAnnotatedReturnType() returns empty AnnotatedType Contributed-by: Joel Borggren-Franck <[email protected]> changeset: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/1916ca1dec2f 8009382: Add JVM_Get{Field|Method}TypeAnnotations Contributed-by: Joel Borggren-Franck <[email protected]> changeset: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/35431a769282 8004823: Add VM support for type annotation reflection Contributed-by: [email protected] *** langtoolschangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/e811fb09a1dcuser: jfranck 8019243: AnnotationTypeMismatchException instead of MirroredTypeExceptionchangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/051e64d0816euser: jfranck8009367: Wrong kind of name used in comparison in javax.lang.model code for repeatable annotationschangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/a218f7befd55user: jfranck8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByTypechangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/67cbd6d756f4user: jfranck8013180: Qualified type reference with annotations in throws list crashes compilerchangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/780014a234fauser: jfranck8013485: javac can't handle annotations with a <clinit> from a previous compilation unitchangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/bae8387d16aauser: jfranck8011027: Type parameter annotations not passed through to javax.lang.modelchangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/a3655c24e232user: jfranck 8012681: Commit for JDK-8012656 breaks tl buildchangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/137994c189e5user: jfranck 7015104: use new subtype of TypeSymbol for type parameterschangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/eb0198033c5cuser: jfranck8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler errorchangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/f427043f8c65user: jfranck 7196531: Duplicate error messages on repeating annotationschangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/7fe9b9d29095user: jfranck 8005205: tests missing bugid for repeating annotation changechangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/aeadaf905d78user: jfranck8007279: Rename javax.l.model.element.Element.getAnnotations(Class) to getAnnotationsByType(Class)changeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/9f42a06a49c0user: jfranck 7193719: Support repeating annotations in javax.lang.modelchangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/f72c9c5aeaefuser: jfranck 8005098: Provide isSynthesized() information on Attribute.Compoundchangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/376d6c1b49e5user: jfranck 8001114: Container annotation is not checked for semantic correctnesschangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/73312ec2cf7cuser: jfranck7199925: Separate compilation breaks check that elements have a default for the containing annotationchangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/873ddd9f4900user: jfranck 7151010: Add compiler support for repeating annotationschangeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/bcd927639039 8004133: Provide javax.lang.model.* implementation backed by core reflection Summary: Joint work by darcy and jfranck to provide sample code for JEP 119.Contributed-by: [email protected], [email protected]changeset: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/ddb4a2bfcd82user: jjg 8013852: update reference impl for type-annotationsContributed-by: [email protected], [email protected], [email protected], [email protected]*** jdk changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/6917c114b197 user: jfranck8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some caseschangeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb7dc7c54145 user: jfranck 8011139: (reflect) Revise checking in getEnclosingClass changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a73ecb5085eb user: jfranck 8007812: (reflect) Class.getEnclosingMethod problematic for some classes Summary: Better checking in getEnclosing(Method|Constructor|Class) changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ba74cd79e4f6 user: jfranck 8007073: Implement Core Reflection for Type Annotations on parameters changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/9c9b2385c1b0 user: jfranck 8013541: Revise javadoc for Executable.getAnnotatedReturnType() changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/38e1821c4472 user: jfranck 8007808: Missing method: Executable.getAnnotatedReturnType() changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2cd67a8c7abc user: jfranck8007278: Rename j.l.r.AnnotatedElement.getAnnotations(Class) to getAnnotationsByType(Class)changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5097fe015763 user: jfranck8005712: Simplify support for repeating annotations in j.l.r.AnnotatedElement 8004919: AnnotationSupport uses possibly half-constructed AnnotationType instances Summary: Implements the simplified semantics for repeating annotations and removes the incorrect obtaining of an AnnotationTypechangeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a343d280bd8c user: jfranck 8004698: Implement Core Reflection for Type Annotations changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/e7edb0da9c6a user: jfranck8004110: Remove debug code form sun/reflect/annotation/AnnotationSupport.javachangeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/735b93462eed user: jfranck 7154390: Add support for repeating annotations in j.l.r.AnnotatedElement changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/599f231cba97 user: jfranck 8001598: Augment ElementType enum for JSR 308 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bdfcc13ddeb4 user: jfranck 7151010: Add compiler support for repeating annotations changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f0bf7358ba23 user: jfranck 7188442: rename java.lang.annotation.ContainerAnnotation to ContainedBy changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/eec133f2406a user: jfranck7158930: (ann) library support for repeating annotations is not built when compiling the JDKchangeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/6d977f61af5e 8004699: Add type annotation storage to Constructor, Field and Method Contributed-by: [email protected]
