On Wed, Aug 28, 2013 at 11:54 PM, Jonathan Gibbons <[email protected]> wrote: > > I hereby nominate Vicente Romero to jdk8 Reviewer. > > Vicente has been a contributor to OpenJDK since 2011, and since > then, he has made a total of 78 contributions and participated in > 38 code reviews, for javac and other tools in the langtools repository.
I don't want to be overly picky and by no means I want to reduce Vincentes merits or his eligibility to be a jdk8 reviewer. I just have a question regarding the whole process: how it can be that somebody who is 'only' a committer has already done 38 code reviews (for change '8013789: Compiler should emit bridges in interfaces' he was even the only reviewer)? It seems like the whole process of electing somebody to be a "reviewer" is pointless, if there are no checks that only "real reviewers" can actually review changes. Regards, Volker > His OpenJDK activity is given below. > > Votes are due by 5 p.m. PDT, September 11. > > Only current jdk8 Reviewers [1] are eligible to vote on > this nomination. Votes must be cast in the open by replying to > this mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > -- Jonathan Gibbons > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > > -------------------- > > Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6917c114b197 > 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some > cases > Reviewed-by: darcy, vromero, psandoz > > Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70c8f4a4b8d6 > user: vromero > 8015780: java/lang/reflect/Method/GenericStringTest.java failing > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25aaff78d754 > user: vromero > 8023112: javac should not use lazy constant evaluation approach for method > references > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a4717f3ea7b > user: vromero > 8022316: Generic throws, overriding and method reference > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/389eaf6ed973 > 7071377: Exception when javac -processor is given a class name with invalid > postfix > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f657d400c736 > 8022508: javac crashes if the generics arity of a base class is wrong > Reviewed-by: mcimadamore, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a6378c19836b > user: vromero > 8022053: javac generates unverifiable initializer for nested subclass of > local class > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ab468194f11 > 8007517: DefaultMethodRegressionTests.java fail in TL > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0ad781399706 > user: vromero > 8013394: compile of iterator use fails with error \"defined in an > inaccessible class or interface\" > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/af80273f630a > 8021567: Javac doesn't report \"java: reference to method is ambiguous\" any > more > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa6c6f8b5622 > user: vromero > 6983297: methods missing from NewArrayTree > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8f282dc58dfc > user: vromero > 8022622: javac, two tests are failing with compile time error after class > Collector was modified > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d9bc764cac7 > user: vromero > 8009640: -profile <compact> does not work when -bootclasspath specified > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d601238641e6 > 8022161: javac Null Pointer Exception in Enter.visitTopLevel > Reviewed-by: jjg, vromero, jlahoda > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b8610a65fbf9 > user: vromero > 8019486: javac, generates erroneous LVT for a test case with lambda code > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c7dcf899ffff > user: vromero > 8008274: javac should not reference/use sample code > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3deeccbf4cf > user: vromero > 8020997: TreeMaker.AnnotationBuilder creates broken element literals with > repeating annotations > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/99b60bcf3862 > user: vromero > 8022186: javac generates dead code if a try with an empty body has a > finalizer > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/05370ef9dccb > 8014826: c.s.t.javac.tree.Pretty.visitNewArray() prints duplicate dimension > markers > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7696282873f6 > user: vromero > 8013179: assertion failure in javac when compiling with -source 1.6 -target > 1.6 > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/39ec5d8a691b > 8016281: The SAM method should be passed to the metafactory as a MethodType > not a MethodHandle > Reviewed-by: jjg, vromero, briangoetz, forax > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a204cf7aab7e > 8012238: Nested method capture and inference > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/866c87c01285 > 8016175: Add bottom-up type-checking support for unambiguous method > references > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/44e27378f523 > 8012242: Lambda compatibility and checked exceptions > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37031963493e > 8020278: NPE in javadoc > Reviewed-by: mcimadamore, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87a951c88a33 > 8013404: Unclear spec for target typing with conditional operator (?:) > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/42b3c5e92461 > 8019824: very long error messages on inference error > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bfbedbfc522a > 8016702: use of ternary operator in lambda expression gives incorrect > results > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0386f0dc28e > 8016059: Cannot compile following lambda > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/70b37cdb19d5 > 8019480: Javac crashes when method is called on a type-variable receiver > from lambda expression > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7b756b307e12 > 8017618: NullPointerException in RichDiagnosticFormatter for bad input > program > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79c3146e417b > user: vromero > 6356530: -Xlint:serial does not flag abstract classes with concrete > methods/members > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d6158f8d7235 > user: vromero > 8009924: some langtools tools do not accept -cp as an alias for -classpath > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b4f92a3797f > user: vromero > 6326693: variable x might already have been assigned, when assignment is in > catch block > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f559ef7568ce > 7034798: Ambiguity error for abstract method call is too eager > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/891c5ecb8306 > user: vromero > 6983646: javap should identify why a DefaultAttribute is being used > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bdd699d7378d > user: vromero > 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses > incorrect format string > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb06c412d079 > user: vromero > 6473148: TreePath.iterator() should document the iteration order > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d137ce373c4c > user: vromero > 7008643: inlined finally clauses confuse debuggers > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e42c27026290 > user: vromero > 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes ) > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8e3d391c88c6 > user: vromero > 8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path, > Attribute.Factory) > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a47e28759666 > user: vromero > 7066788: javah again accepts -old option (ineffectively) which was removed > in 1.5. > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c2d9303c3477 > 8016908: TEST_BUG: removing non-ascii characters causes tests to fail > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/831467c4c6a7 > user: vromero > 8017104: javac should have a class for primitive types that inherits from > Type > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6d3b33aea370 > user: vromero > 8006981: javac, method toString() of class ...javac.code.Flags doesn't print > all the flag bits > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9851071b551a > user: vromero > 8016267: javac, TypeTag refactoring has provoked performance issues > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/455be95bd1b5 > 8013789: Compiler should emit bridges in interfaces > Reviewed-by: vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1936a884b290 > user: vromero > 8008023: Get rid of utf8 chars in two tests > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7fe655cad9b1 > user: vromero > 8007907: javap, method com.sun.tools.javap.Main.run returns 0 even in case > of class not found error > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bbedff0dc37e > user: vromero > 8008547: javac, warning message: use of ''_'' as an identifier might not be > supported in future releases, should be more especific > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3582b62dccb2 > 8013576: Add stat support to LambdaToMethod > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/105d1f9c1ab8 > user: vromero > 7113519: test/tools/javac/VersionOpt.java passes on windows > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f218bb5ebd53 > 8015648: Duplicate variable in lambda causes javac crash > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f8472e561a97 > 8015432: javac crashes with stack overflow when method called recursively > from nested generic call > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/349160289ba2 > 8008627: Compiler mishandles three-way return-type-substitutability > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7889d1fe2597 > 7139681: Enhanced for loop: local variable scope inconsistent with JLS > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e30a513c945 > 6360970: javac erroneously accept ambiguous field reference > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/775a51e3276f > user: vromero > 7165659: javac incorrectly sets strictfp access flag on inner-classes > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/242bcad5be74 > 8006615: [doclint] move remaining messages into resource bundle > Reviewed-by: mcimadamore, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec871c3e8337 > user: vromero > 6695379: Copy method annotations and parameter annotations to synthetic > bridge methods > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e9855150c5b0 > user: vromero > 8010737: javac, known parameter's names should be copied to automatically > generated constructors for inner classes > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f11c7676cd5 > user: vromero > 7179353: try-with-resources fails to compile with generic exception > parameters > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/92e420e9807d > user: vromero > 7053059: VerifyError with double Assignment using a Generic Member of a > Superclass > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d042cba65eab > user: vromero > 8012333: javac, ClassFile should have a read(Path) method > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c6df5b20f9eb > user: vromero > 6970173: Debug pointer at bad position > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b391ecea538e > user: vromero > 7030476: Fix conflicting use of JCTree/JCExpression > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e5076af4660 > 8014494: javac crashes when varargs element of a method reference is > inferred from the context > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97a9b4b3e63a > 8014649: Regression: bug in Resolve.resolveOperator > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/58329d9f6b68 > 8014643: Parser regression in JDK 8 when compiling super.x > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/08daea43a7f8 > user: vromero > 7164114: Two jtreg tests are not run due to no file extension on the test > files > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37295244f534 > user: vromero > 8005207: test has 2 @bug tags > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d9750039fff > user: vromero > 7060779: test/tools/javac/diags/Example.java leaves directories in tempdir > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/824932ecdbc8 > user: vromero > 7177168: Redundant array copy in UnsharedNameTable > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/78717f2d00e8 > 8013222: Javac issues spurious raw type warnings when lambda has implicit > parameter types > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/33d1937af1a3 > 8012685: Spurious raw types warning when using unbound method references > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/05ec778794d0 > 8012003: Method diagnostics resolution need to be simplified in some cases > Reviewed-by: jjg, vromero > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/43c2f7cb9c76 > 8004082: test/tools/javac/plugin/showtype/Test.java fails on windows: jtreg > can't delete plugin.jar > Reviewed-by: vromero, mcimadamore > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a2889739cf21 > 8000407: remove @GenerateNativeHeader > Reviewed-by: vromero, darcy > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abd153854f16 > 8012728: Normalize @ignore comments on langtools tests > Reviewed-by: vromero, mcimadamore > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3f3ac1273e8 > user: vromero > 8010304: javac should detect all mutable implicit static fields in langtools > using a plugin > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2ca9e7d50136 > user: vromero > 8008562: javac, a refactoring to Bits is necessary in order to provide a > change history > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3c02d2f1a421 > user: vromero > 8012723: strictfp interface misses strictfp modifer on default method > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a3655c24e232 > 8012681: Commit for JDK-8012656 breaks tl build > Reviewed-by: vromero, chegar, alanb > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/49d32c84dfea > user: vromero > 8011181: javac, empty UTF8 entry generated for inner class > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a4be2c2fe0a1 > user: vromero > 8011432: javac, compiler regression iterable + captured type > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/29c6984a1673 > user: vromero > 4965689: class literal code wastes a byte > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fa24eba012bd > user: vromero > 5053846: javac: MethodRef entries are duplicated in the constant pool > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2e21ecd7a5ad > user: vromero > 8008582: jtreg failures after conversion of shell tests to Java > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c61add6bf8ac > user: vromero > 6181889: Empty try/finally results in bytecodes being generated > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/823fb9229724 > user: vromero > 8009170: Regression: javac generates redundant bytecode in assignop > involving arrays > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3806171b52d8 > user: vromero > 8009138: javac, equals-hashCode warning tuning > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bd49e0304281 > user: vromero > 8008436: javac should not issue a warning for overriding equals without > hasCode if hashCode has been overriden by a superclass > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dc8b7aa7cef3 > user: vromero > 8006212: javac, convert jtreg tests from shell script to java > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2620c953e9fe > user: vromero > 6563143: javac should issue a warning for overriding equals without hashCode > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/073696f59241 > user: vromero > 8006334: javap, JavapTask constructor breaks with null pointer exception if > parameter options is null > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/017e8bdd440f > user: vromero > 7167125: Two variables after the same operation in a inner class return > different results > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b1deb90d2e37 > user: vromero > 8005931: javac doesn't set ACC_STRICT for classes with package access > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/762d0af062f5 > user: vromero > 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a51a8dac0a2f > user: vromero > 7199823: javac generates inner class that can't be verified > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4cc73ec94686 > user: vromero > 8005075: Pool.Method, and Pool.Variable redundant Symbol field should be > removed > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cbcd9b484759 > user: vromero > 8006944: javac, combo tests should print out the number of threads used > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/954541f13717 > user: vromero > 8005167: execution time of combo tests in javac should be improved > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/de1ec6fc93fe > user: vromero > 8000518: Javac generates duplicate name_and_type constant pool entry for > class BinaryOpValueExp.java > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37a5d7eccb87 > user: vromero > 8004976: test/tools/javac/7153958/CPoolRefClassContainingInlinedCts.java can > fail > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fcf89720ae71 > user: vromero > 8003967: detect and remove all mutable implicit static enum fields in > langtools > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/969c96b980b7 > user: vromero > 7153958: add constant pool reference to class containing inlined constants > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f41a5758cf7 > user: vromero > 7144981: javac should ignore ignorable characters in input > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3746b071d75b > user: vromero > 6574624: javax.tools.JavaCompiler spec contains errors in sample code > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d9fe1f80515d > user: vromero > 7190862: javap shows an incorrect type for operands if the 'wide' prefix is > used > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/19d6ba779759 > user: vromero > 8000484: Bad error recovery when 'catch' without 'try' is found > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2443d24d096a > user: vromero > 6949443: visitTree assertion triggered using -Xjcov on small sample program > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/75c936d14c6a > user: vromero > 8000483: cryptic error message when source file contains hash > Contributed-by: [email protected] > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ea2616a6bd01 > 6725230: Java Compilation with Jsr199 ignores Class-Path in manifest > Contributed-by: [email protected] > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c002fdee76fd > 7200915: convert TypeTags from a series of small ints to an enum > Contributed-by: [email protected] > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0e5899f09dab > 7193657: provide internal ArrayUtils class to simplify common usage of > arrays in javac > Contributed-by: [email protected] > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ca49d50318dc > 6921494: provide way to print javac tree tag values > Contributed-by: [email protected] > > Summary: > Earliest: Tue Nov 08 11:51:05 PST 2011 > Commits: 73 > Contributions: 5 > Reviews: 38
