Cool stuff! I like your green/red diff tool. Don't have to click through each individual webrev page.

Just one thing to confirm but you would know better: was there anything that impacts L10N? I didn't see anything obvious.

Brad


On 10/31/2013 5:58 AM, sergey malenkov wrote:
Hi Stuart,

I've attached a file with all typos which had been left after the fix.
There are no any occured in jdk/src.

Thanks,
SAM

On 31.10.2013 5:59, Stuart Marks wrote:
Perhaps Sergey can check.

I would have checked myself, but Sergey pushed his earlier fix to the
AWT forest, and I don't think it's appeared in TL yet. I could have
pulled over the AWT forest, but I have enough distractions as it stands.

Hm, maybe we need a new Friday Stats metric: the numbre of occurances
of mispeled words.

s'marks


On 10/30/13 1:40 PM, Jonathan Gibbons wrote:
find/grep before and after?

-- Jon

On 10/30/2013 01:17 PM, Stuart Marks wrote:
The changes look good.

It looks like "occured" is the most common spelling error. I wonder
how many
instances of this misspelling will remain in the codebase after your
fixes.

s'marks

On 10/30/13 4:43 AM, sergey malenkov wrote:
Hello,

Could you please review the following fix:
fix:http://cr.openjdk.java.net/~malenkov/8026491.8.0/
bug:https://bugs.openjdk.java.net/browse/JDK-8026491

I've replaced all typos with correct words in all string literals.

This is a second part of the previous fix
(8022746: List of spelling errors in API doc).

Thanks,
SAM


Reply via email to