On Jun 4, 2005, at 2:00 PM, [EMAIL PROTECTED] wrote:
<x-tad-bigger>Hi,</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>While running the tck tests I found these issues:</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>1. Below the class name is incorrect</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>Index: F:/eclipse-new/eclipse/workspace/tck20/test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/FieldsOfPrimitiveboolean-derby.orm</x-tad-bigger>
<x-tad-bigger>===================================================================</x-tad-bigger>
<x-tad-bigger>--- F:/eclipse-new/eclipse/workspace/tck20/test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/FieldsOfPrimitiveboolean-derby.orm (revision 179987)</x-tad-bigger>
<x-tad-bigger>+++ F:/eclipse-new/eclipse/workspace/tck20/test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/FieldsOfPrimitiveboolean-derby.orm (working copy)</x-tad-bigger>
<x-tad-bigger>@@ -2,7 +2,7 @@</x-tad-bigger>
<x-tad-bigger> <!DOCTYPE orm PUBLIC "-//Sun Microsystems, Inc.//DTD Java Data Objects Mapping Metadata 2.0//EN" "http://java.sun.com/dtd/orm_2_0.dtd"></x-tad-bigger>
<x-tad-bigger> <orm></x-tad-bigger>
<x-tad-bigger> <package name="org.apache.jdo.tck.pc.fieldtypes"></x-tad-bigger>
<x-tad-bigger>- <class name="FieldsOfPrimitiveBoolean" table="FIELDSOFPRIMITIVEBOOLEAN"></x-tad-bigger>
<x-tad-bigger>+ <class name="FieldsOfPrimitiveboolean" table="FIELDSOFPRIMITIVEBOOLEAN"></x-tad-bigger>
<x-tad-bigger> <datastore-identity strategy="identity" column="IDENTIFIER"/></x-tad-bigger>
<x-tad-bigger> <field name="boolean0" column="BOOLEAN0"/></x-tad-bigger>
<x-tad-bigger> <field name="boolean1" column="BOOLEAN1"/></x-tad-bigger>
Done fixed. Thanks.
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>2. In datastore tests, the id field is not persistent.</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>Index: F:/eclipse-new/eclipse/workspace/tck20/test/jdo/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/SimpleClass.jdo</x-tad-bigger>
<x-tad-bigger>===================================================================</x-tad-bigger>
<x-tad-bigger>--- F:/eclipse-new/eclipse/workspace/tck20/test/jdo/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/SimpleClass.jdo (revision 179987)</x-tad-bigger>
<x-tad-bigger>+++ F:/eclipse-new/eclipse/workspace/tck20/test/jdo/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/SimpleClass.jdo (working copy)</x-tad-bigger>
<x-tad-bigger>@@ -4,6 +4,7 @@</x-tad-bigger>
<x-tad-bigger> <package name="org.apache.jdo.tck.pc.fieldtypes"></x-tad-bigger>
<x-tad-bigger> <class name="SimpleClass" identity-type="datastore"></x-tad-bigger>
<x-tad-bigger> <implements name="SimpleInterface"/></x-tad-bigger>
<x-tad-bigger>+ <field name="id" persistence-modifier="none"/></x-tad-bigger>
<x-tad-bigger> </class></x-tad-bigger>
<x-tad-bigger> </package></x-tad-bigger>
<x-tad-bigger> </jdo></x-tad-bigger>
This is a bigger issue. All of the datastore identity jdo files have to be fixed to have the id fields be persistent, and add a column to be used for the datastore identity.
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>3. Here the simple class definition was again defined, so I removed it</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>Index: F:/eclipse-new/eclipse/workspace/tck20/test/jdo/datastoreidentity/org/apache/jdo/tck/package.jdo</x-tad-bigger>
<x-tad-bigger>===================================================================</x-tad-bigger>
<x-tad-bigger>--- F:/eclipse-new/eclipse/workspace/tck20/test/jdo/datastoreidentity/org/apache/jdo/tck/package.jdo (revision 179987)</x-tad-bigger>
<x-tad-bigger>+++ F:/eclipse-new/eclipse/workspace/tck20/test/jdo/datastoreidentity/org/apache/jdo/tck/package.jdo (working copy)</x-tad-bigger>
<x-tad-bigger>@@ -26,9 +26,5 @@</x-tad-bigger>
<x-tad-bigger> <class name="NoAccessToFieldsAfterPredelete" persistence-modifier="persistence-aware"/></x-tad-bigger>
<x-tad-bigger> <class name="TestParts" persistence-modifier="persistence-aware"/></x-tad-bigger>
<x-tad-bigger> </package></x-tad-bigger>
<x-tad-bigger>- <package name="org.apache.jdo.tck.pc.fieldtypes"></x-tad-bigger>
<x-tad-bigger>- <class name="SimpleClass" identity-type="datastore"></x-tad-bigger>
<x-tad-bigger>- <implements name="SimpleInterface"/></x-tad-bigger>
<x-tad-bigger>- </class></x-tad-bigger>
<x-tad-bigger>- </package></x-tad-bigger>
<x-tad-bigger>+</x-tad-bigger>
<x-tad-bigger> </jdo></x-tad-bigger>
This was done to make sure the JDO implementation read the metadata for the class SimpleClass before it read any of the metadata that used the SimpleInterface. The duplicate definition in pc.fieldtypes should be ignored according to the specification.
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>4. JPOX can’t find the implementation classes.</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>Fixed. Get the latest nightly build.</x-tad-bigger>
Great. Thanks.
<x-tad-bigger> </x-tad-bigger>Do you happen to have a patch for this one? ;-)
<x-tad-bigger>5. Fields of simple interface are using BLOB types to store data in all fields.</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>It should only use </x-tad-bigger><x-tad-bigger>LONG VARCHAR FOR BIT DATA</x-tad-bigger><x-tad-bigger> types for the fields that are marked as embedded in the metadata. For all non embedded fields, the column should have a FK to the table Simple class.</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>CREATE TABLE FIELDSOFSIMPLEINTERFACE</x-tad-bigger>
<x-tad-bigger>(</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger><x-tad-bigger>IDENTIFIER INTEGER NOT NULL GENERATED ALWAYS AS IDENTITY,</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger><x-tad-bigger>SIMPLEINTERFACE1 LONG VARCHAR FOR BIT DATA,</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger><x-tad-bigger>SIMPLEINTERFACE102 LONG VARCHAR FOR BIT DATA,</x-tad-bigger>
<x-tad-bigger>….</x-tad-bigger>
<x-tad-bigger> </x-tad-bigger>
Thanks for taking a look at these. Are you now able to run all the tests?
Craig
<x-tad-bigger> </x-tad-bigger>Craig Russell
<x-tad-bigger> </x-tad-bigger>
<x-tad-bigger>Erik Bengtson</x-tad-bigger>
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!
smime.p7s
Description: S/MIME cryptographic signature
