Hi Craig,

looks good!

Some comments:
- ObjectIdentity:
The class calls JDOImplHelper.getInstance() and stores the result in an instance variable. I propose to make the instance variable be static. Furthermore, do we need a doPrivileged around the call JDOImplHelper.getInstance, since it requires JDOPermission("getMetadata")?
- Bundle.properties
Please add a newline at the end of the file.

Regards Michael

Hi,

This is still a work in progress, pending inclusion of the JDONullIdentityFIeldException. But the ObjectIdentity class is mostly done.

Craig


--
Michael Bouschen                [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED]        http://www.tech.spree.de/
Tel.:++49/30/235 520-33         Buelowstr. 66                   
Fax.:++49/30/2175 2012          D-10783 Berlin                  

Reply via email to