Re: Patch for JIRA JDO-96

Wed, 27 Jul 2005 04:20:25 -0700 

Hi Craig,

I'm working under Windows.
Files which I create using Eclipse, File Explorer, or a Windows editor, have access rights 777 by default. The same holds true for files, which are created by the SUN JVM for Windows. For example, the log files created under ".../tck20/target/logs/" have access rights 777.
Files which are created by svn, e.g. when I call "svn update", have different access rights: 

- Directories always have 777.
- Files which have been created by my patches have 666.
- All other files have 777.
Actually, I would have assumed the opposite: Files created by my patches have 777 and all other files have 666. Have you changed the access rights of newly created files explicitly before you commited my patches?
However, I do not know how to change the Windows default of file access rights. We filed a ticket at Windows Hotline... 

Regards,
Michael

Hi Michael,

On Jul 26, 2005, at 8:50 AM, Michael Watzek wrote:


Hi Craig,

I'll have to leave now and will check that tomorrow.
Do you mean the "org/apache/jdo/tck/pc/singlefieldidentity/package.jdo" under directory applicationidentity? 


I mean:
Property changes on: test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo 
___________________________________________________________________
Name: svn:executable
   + *



Why is it svn:executable?
I noticed a number of such svn:executable but this is the first time I questioned it... 

Thanks,

Craig



Regards,
Michael



Hi Michael,
Thanks for the patch.
Question: Why is the package.jdo file marked as "executable" in svn? Configuration error in your maven setup? 
Craig
On Jul 26, 2005, at 6:04 AM, Michael Watzek wrote:


Hi Michelle,
please find the attached patch fixing JIRA JDO-96 (Error reading the JDO Meta-Data file "org/apache/jdo/tck/pc/singlefieldidentity/package.jdo". Cause : {1}). The patch adds a package JDO file to package "org.apache.jdo.tck.pc.singlefieldidentity" for datastoreidentity. All classes listed in that file have attribute "persistence-modifier" set to "non-persistent". 

Regards,
Michael
--
-------------------------------------------------------------------
Michael Watzek                  [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED]        Buelowstr. 66
Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
Fax.:  ++49/30/217 520 12       http://www.spree.de/
-------------------------------------------------------------------
Index: test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo 
===================================================================
--- test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo (revision 0) +++ test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo (revision 0) 
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE jdo PUBLIC "-//Sun Microsystems, Inc.//DTD Java Data Objects Metadata 2.0//EN" "http://java.sun.com/dtd/jdo_2_0.dtd";> 
+
+<jdo>
+  <package name="org.apache.jdo.tck.pc.singlefieldidentity">
+ <class name="PCPointSingleFieldPrimitivebyte" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldByte" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldPrimitivechar" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldCharacter" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldPrimitiveint" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldInteger" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldPrimitivelong" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldLong" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldPrimitiveshort" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldShort" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldString" persistence-modifier="non-persistent"/> + <class name="PCPointSingleFieldDate" persistence-modifier="non-persistent"/> 
+  </package>
+</jdo>
+
Property changes on: test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo 
___________________________________________________________________
Name: svn:executable
   + *




Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!




--
-------------------------------------------------------------------
Michael Watzek                  [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED]        Buelowstr. 66
Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
Fax.:  ++49/30/217 520 12       http://www.spree.de/
-------------------------------------------------------------------



Craig Russell

Architect, Sun Java Enterprise System http://java.sun.com/products/jdo

408 276-5638 mailto:[EMAIL PROTECTED]

P.S. A good JDO? O, Gasp!





--
-------------------------------------------------------------------
Michael Watzek                  [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED]        Buelowstr. 66
Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
Fax.:  ++49/30/217 520 12       http://www.spree.de/
-------------------------------------------------------------------

Reply via email to